Added mock library for SmmServicesTableLib and mock protocol for SmmCpu #784
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
impact:non-functional
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## release/202311 #784 +/- ##
==================================================
+ Coverage 1.06% 1.23% +0.17%
==================================================
Files 1302 1302
Lines 330332 332095 +1763
Branches 6686 6686
==================================================
+ Hits 3515 4117 +602
- Misses 326367 327902 +1535
+ Partials 450 76 -374
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
apop5
approved these changes
Apr 2, 2024
VivianNK
approved these changes
Apr 2, 2024
v-bhavanisu
force-pushed
the
personal/bhavani/SmmServicesTableLib2
branch
from
7feb758
to
2a32406
Compare
v-bhavanisu
force-pushed
the
personal/bhavani/SmmServicesTableLib2
branch
from
2a32406
to
804d06d
Compare
ProjectMuBot
referenced
this pull request
in microsoft/mu_tiano_platforms
Apr 5, 2024
Introduces 3 new commits in [MU_BASECORE](https://github.com/microsoft/mu_basecore.git). <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/microsoft/mu_basecore/commit/ac3f06670050c3ea61ae606f9e9d28192915d6aa">ac3f06</a> Added mock library for SmmServicesTableLib and mock protocol for SmmCpu (<a href="https://github.com/microsoft/mu_basecore/pull/784">#784</a>)</li> <li><a href="https://github.com/microsoft/mu_basecore/commit/96f6943d89fb22d4c256fb3c2032c1306f26ec84">96f694</a> pip: update edk2-pytool-library requirement from ~=0.21.4 to ~=0.21.5 (<a href="https://github.com/microsoft/mu_basecore/pull/787">#787</a>)</li> <li><a href="https://github.com/microsoft/mu_basecore/commit/8a0ac50c434ed1187a6379d30733d720224f31fe">8a0ac5</a> Added Mock Library for IoLib (<a href="https://github.com/microsoft/mu_basecore/pull/788">#788</a>)</li> </ul> </details> Signed-off-by: Project Mu Bot <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added mock library for SmmServicesTableLib and mock protocol for SmmCpu
flow, or firmware?
validation improvement, ...
in build or boot behavior?
a function in a new library class in a pre-existing module, ...
outside direct code modifications (and comments)?
on an a separate Web page, ...
How This Was Tested
Added this mock lib and mock protocol to Gen11 library and ensured no build errors
Integration Instructions
N/A