[Rebase & FF] 202405: Add mocks and stubs using the old framework #900
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VivianNK
changed the title
os-d
approved these changes
Jun 27, 2024
VivianNK
force-pushed
the
personal/vnowkakeane/mocks
branch
from
3c702f3
to
f2154cb
Compare
github-actions
bot
added
the
impact:non-functional
VivianNK
force-pushed
the
personal/vnowkakeane/mocks
branch
3 times, most recently
from
7911fc6
to
b62cf27
Compare
VivianNK
force-pushed
the
personal/vnowkakeane/mocks
branch
from
b62cf27
to
48b0d94
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## release/202405 #900 +/- ##
=================================================
Coverage ? 0.97%
=================================================
Files ? 1126
Lines ? 260648
Branches ? 0
=================================================
Hits ? 2551
Misses ? 258097
Partials ? 0
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
makubacki
reviewed
Jul 10, 2024
makubacki
reviewed
Jul 10, 2024
makubacki
approved these changes
Jul 10, 2024
VivianNK
force-pushed
the
personal/vnowkakeane/mocks
branch
3 times, most recently
from
6c51eaa
to
9dae06b
Compare
apop5
approved these changes
Jul 16, 2024
makubacki
approved these changes
Jul 16, 2024
|
Nit: You only need to add a co-author for the person that is not the author. |
github-actions
bot
added
the
impact:breaking-change
VivianNK
force-pushed
the
personal/vnowkakeane/mocks
branch
3 times, most recently
from
081adab
to
6ff4a0c
Compare
Create stubs for HobLib and UefiLib. Create mocks for UefiBootServicesTableLib and UefiRuntimeServicesTableLib Co-authored-by: Vivian Nowka-Keane <[email protected]>
For DxeResetSystemLibUnitTestHost, use mock from MdePkg. Co-authored-by: Vivian Nowka-Keane <[email protected]>
VivianNK
force-pushed
the
personal/vnowkakeane/mocks
branch
from
6ff4a0c
to
6ac543e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add mocks and stubs using Cmocka. Move existing
MockUefiRuntimeServicesTableLibto proper home.Includes MU_CHANGE changes to take to edk2
Cherry picked and squashed the following commits:
d41aacf
6636c59
c3254d1
891ce90
How This Was Tested
Changes from release/202311
Integration Instructions
Upgrading from 202311 to 202405 -> No change for platform
Upgrading from edk2 -> 202405, change the path as follows:
Unit Test Cmocka mock moved - Any unit test using the mock
MdeModulePkg/Library/DxeResetSystemLib/UnitTest/MockUefiRuntimeServicesTableLib.infneeds to update its path to
MdePkg/Test/Mock/Library/Cmocka/MockUefiRuntimeServicesTableLib/MockUefiRuntimeServicesTableLib.inf