Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Rebase & FF] 202405: Basecore Standalone MM Changes #924

Merged
merged 4 commits into from
Jul 5, 2024

Conversation

cfernald
Copy link
Contributor

Description

Cherry-pick and condense standalone MM changes.

cherry-picks:
1f75b27
d4dff6b
03d53bb
57e8694
48e90b7
271a1a0
8254b47

  • Impacts functionality?
  • Impacts security?
  • Breaking change?
  • Includes tests?
  • Includes documentation?

How This Was Tested

N/A

Integration Instructions

N/A

@cfernald cfernald requested a review from os-d July 1, 2024 20:46
@makubacki makubacki force-pushed the 2405_standalone_mm branch 2 times, most recently from 66cdc31 to b489662 Compare July 2, 2024 14:20
@codecov-commenter
Copy link

codecov-commenter commented Jul 2, 2024

Codecov Report

Attention: Patch coverage is 0% with 13 lines in your changes missing coverage. Please review.

Please upload report for BASE (release/202405@27a2ec1). Learn more about missing BASE report.

Files Patch % Lines
MdeModulePkg/Core/PiSmmCore/PiSmmIpl.c 0.00% 13 Missing ⚠️
Additional details and impacted files
@@                Coverage Diff                @@
##             release/202405     #924   +/-   ##
=================================================
  Coverage                  ?    0.82%           
=================================================
  Files                     ?     1420           
  Lines                     ?   356371           
  Branches                  ?     4336           
=================================================
  Hits                      ?     2954           
  Misses                    ?   352697           
  Partials                  ?      720           
Flag Coverage Δ
MdeModulePkg 0.20% <0.00%> (?)
MdePkg 3.30% <ø> (?)
NetworkPkg 0.55% <ø> (?)
UefiCpuPkg 2.90% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

makubacki and others added 4 commits July 5, 2024 10:27
This is a NULL class library with a constructor that registers
notifications on data sources needed to produce HOBs consumed
within the Standalone MM core environment.

The data source must be a standard based API so the library
remains portable.

cherry-pick from 8254b47
…MUNICATE_HEADER for both IA32 and X64

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3398
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3430

These changes update references to the MessageLength field of EFI_MM_COMMUNICATE_HEADER.
This structure can be used for both PEI and DXE MM communication. Thus, for
a system that supports PEI MM launch but operates PEI in 32bit mode and MM foundation in 64bit,
the current EFI_MM_COMMUNICATE_HEADER definition will cause structure parse error due to UINTN used.

cherry-pick from 271a1a0
When building standalone MM core module, the relocation is also
disabled and this will introduce a linker break when this is done
with GCC.

Thus extending the flag to cover GCC builds as well.

cherry-pick from 57e8694

Signed-off-by: Kun Qin <[email protected]>
This change added the long vacant `MmServicesTableLib` for MM core instance.
The implementation will use extern to link the gMmst to the global MM table,
so that the libraries can use gMmst more generically.

cherry-pick from 03d53bb, d4dff6b, 1f75b27
@cfernald cfernald merged commit 378ba56 into microsoft:release/202405 Jul 5, 2024
29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants