Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MdeModulePkg/Core/Dxe/DxeMain/DxeMain: Add late initialization for Debug Agent. #992

Open
wants to merge 1 commit into
base: release/202405
Choose a base branch
from

Conversation

apop5
Copy link
Contributor

@apop5 apop5 commented Jun 27, 2024

Description

Adds a late initialize in DxeMain for the debug agent. This is required for the debug agent to be able to setup events to handle image loads, exit boot services, and other important callbacks.

66197bc9af

  • Impacts functionality?
    • Functionality - Does the change ultimately impact how firmware functions?
    • Examples: Add a new library, publish a new PPI, update an algorithm, ...
  • Impacts security?
    • Security - Does the change have a direct security impact on an application,
      flow, or firmware?
    • Examples: Crypto algorithm change, buffer overflow fix, parameter
      validation improvement, ...
  • Breaking change?
    • Breaking change - Will anyone consuming this change experience a break
      in build or boot behavior?
    • Examples: Add a new library class, move a module to a different repo, call
      a function in a new library class in a pre-existing module, ...
  • Includes tests?
    • Tests - Does the change include any explicit test code?
    • Examples: Unit tests, integration tests, robot tests, ...
  • Includes documentation?
    • Documentation - Does the change contain explicit documentation additions
      outside direct code modifications (and comments)?
    • Examples: Update readme file, add feature readme file, link to documentation
      on an a separate Web page, ...

How This Was Tested

Tested on Qemu

Integration Instructions

N/A

@codecov-commenter
Copy link

codecov-commenter commented Jun 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (release/202405@bb2f962). Learn more about missing BASE report.

Additional details and impacted files
@@                Coverage Diff                @@
##             release/202405     #992   +/-   ##
=================================================
  Coverage                  ?   26.74%           
=================================================
  Files                     ?      170           
  Lines                     ?    21754           
  Branches                  ?     5350           
=================================================
  Hits                      ?     5818           
  Misses                    ?    15871           
  Partials                  ?       65           
Flag Coverage Δ
MdeModulePkg 17.80% <ø> (?)
NetworkPkg 8.53% <ø> (?)
UefiCpuPkg 39.84% <ø> (?)
UnitTestFrameworkPkg 6.01% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@makubacki makubacki requested a review from cfernald June 27, 2024 22:02
…bug Agent.

Adds a late initialize in DxeMain for the debug agent. This is required
for the debug agent to be able to setup events to handle image loads,
exit boot services, and other important callbacks.
@apop5 apop5 force-pushed the personal/apop5/latedebugagent branch from 1c93181 to 0d304cd Compare June 27, 2024 22:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants