Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New write_csv_detailed() to dump out data in expanded format #365

Open
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

nancykhoury
Copy link

@nancykhoury nancykhoury commented Jun 13, 2024

Preface

Please ensure you have read the contribution docs prior
to submitting the pull request. In particular,
pull request guidelines.

Description

<Please include a description of the change and why this change was made.>

For each item, place an "x" in between [ and ] if true. Example: [x].
(you can also check items in the GitHub UI)

  • Impacts functionality?
    • Functionality - Does the change ultimately impact how firmware functions?
    • Examples: Add a new library, publish a new PPI, update an algorithm, ...
  • Impacts security?
    • Security - Does the change have a direct security impact on an application,
      flow, or firmware?
    • Examples: Crypto algorithm change, buffer overflow fix, parameter
      validation improvement, ...
  • Breaking change?
    • Breaking change - Will anyone consuming this change experience a break
      in build or boot behavior?
    • Examples: Add a new library class, move a module to a different repo, call
      a function in a new library class in a pre-existing module, ...
  • Includes tests?
    • Tests - Does the change include any explicit test code?
    • Examples: Unit tests, integration tests, robot tests, ...
  • Includes documentation?
    • Documentation - Does the change contain explicit documentation additions
      outside direct code modifications (and comments)?
    • Examples: Update readme file, add feature readme file, link to documentation
      on an a separate Web page, ...

How This Was Tested

<Please describe the test(s) that were run to verify the changes.>

Integration Instructions

<Describe how these changes should be integrated. Use N/A if nothing is required.>

@github-actions github-actions bot added language:python Pull requests that update Python code impact:non-functional Does not have a functional impact labels Jun 13, 2024
SetupDataPkg/Tools/VariableList.py Show resolved Hide resolved
SetupDataPkg/Tools/VariableList.py Show resolved Hide resolved
SetupDataPkg/Tools/VariableList.py Outdated Show resolved Hide resolved
@codecov-commenter
Copy link

codecov-commenter commented Jun 13, 2024

Codecov Report

Attention: Patch coverage is 3.12500% with 31 lines in your changes missing coverage. Please review.

Project coverage is 36.07%. Comparing base (ae0f15a) to head (dc1b569).

Current head dc1b569 differs from pull request most recent head de7fc0d

Please upload reports for the commit de7fc0d to get more accurate results.

Files Patch % Lines
SetupDataPkg/Tools/VariableList.py 3.12% 31 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #365      +/-   ##
==========================================
- Coverage   36.24%   36.07%   -0.17%     
==========================================
  Files          31       31              
  Lines        6258     6290      +32     
  Branches      669      669              
==========================================
+ Hits         2268     2269       +1     
- Misses       3984     4015      +31     
  Partials        6        6              
Flag Coverage Δ
Linux 27.39% <3.12%> (-0.17%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@os-d os-d requested review from apop5 and Brent-A June 13, 2024 23:57
…Value' in the header row for compatibility with the existing read_csv() function.
@nancykhoury
Copy link
Author

@microsoft-github-policy-service agree company="Microsoft"

SetupDataPkg/Tools/VariableList.py Show resolved Hide resolved
SetupDataPkg/Tools/VariableList.py Outdated Show resolved Hide resolved
SetupDataPkg/Tools/VariableList.py Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
impact:non-functional Does not have a functional impact language:python Pull requests that update Python code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants