Fix invalid access of NewRecoveryChallenge when memory allocation fails #168
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
impact:non-functional
makubacki
reviewed
Dec 6, 2023
makubacki
approved these changes
Dec 6, 2023
NishanthSanjeevi
approved these changes
Dec 6, 2023
kenlautner
approved these changes
Dec 6, 2023
ProjectMuBot
referenced
this pull request
in microsoft/mu_tiano_platforms
Dec 7, 2023
Introduces 2 new commits in [Features/DFCI](https://github.com/microsoft/mu_feature_dfci). <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/microsoft/mu_feature_dfci/commit/7534399474bf61cecb1f3ff1dfae9a72e62b3538">753439</a> pip: bump edk2-pytool-library from 0.19.6 to 0.19.7 (<a href="https://github.com/microsoft/mu_feature_dfci/pull/167">#167</a>)</li> <li><a href="https://github.com/microsoft/mu_feature_dfci/commit/8978086615efe0a59fcaa3782fa46c6f11bc65b8">897808</a> Fix invalid access of NewRecoveryChallenge when memory allocation fails (<a href="https://github.com/microsoft/mu_feature_dfci/pull/168">#168</a>)</li> </ul> </details> Signed-off-by: Project Mu Bot <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
If memory allocation for the NewChallenge variable should not be used. It will result in Invalid access at the following line.
NewChallenge->SerialNumber = 0;
With this change if memory allocation for the NewChallenge variable fails, EFI_OUT_OF_RESOURCES is returned
How This Was Tested
Build passes with this change
Integration Instructions
N/A