Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

.github/workflows/publish-qemu-bin.yml: reliability updates #880

Merged
merged 3 commits into from
Mar 14, 2024

Conversation

Javagedes
Copy link
Contributor

Description

Updates release pipeline for the qemu binary to release qemu v7.2.0 as a external dependency and to also provide the following roms:

  • efi-e1000e.rom

  • efi-virtio.rom

  • Impacts functionality?

    • Functionality - Does the change ultimately impact how firmware functions?
    • Examples: Add a new library, publish a new PPI, update an algorithm, ...
  • Impacts security?

    • Security - Does the change have a direct security impact on an application,
      flow, or firmware?
    • Examples: Crypto algorithm change, buffer overflow fix, parameter
      validation improvement, ...
  • Breaking change?

    • Breaking change - Will anyone consuming this change experience a break
      in build or boot behavior?
    • Examples: Add a new library class, move a module to a different repo, call
      a function in a new library class in a pre-existing module, ...
  • Includes tests?

    • Tests - Does the change include any explicit test code?
    • Examples: Unit tests, integration tests, robot tests, ...
  • Includes documentation?

    • Documentation - Does the change contain explicit documentation additions
      outside direct code modifications (and comments)?
    • Examples: Update readme file, add feature readme file, link to documentation
      on an a separate Web page, ...

How This Was Tested

Verified Terminal was not in an invalid state after exiting qemu, and that the above roms were successfully found at runtime.

Integration Instructions

Perform a release and update the qemu external dependency inside mu_tiano_platforms

@github-actions github-actions bot added the impact:non-functional Does not have a functional impact label Mar 13, 2024
@Javagedes Javagedes merged commit eb3155b into microsoft:main Mar 14, 2024
31 checks passed
@Javagedes Javagedes mentioned this pull request Mar 14, 2024
5 tasks
Javagedes added a commit that referenced this pull request Mar 14, 2024
## Description

Update the qemu extdep to the latest mu_tiano_platforms release. This
downgrades qemu to a more reliable version - 7.2.0 and also adds the
following two roms:

- efi-e1000e.rom
- efi-virtio.rom

- [ ] Impacts functionality?
- **Functionality** - Does the change ultimately impact how firmware
functions?
- Examples: Add a new library, publish a new PPI, update an algorithm,
...
- [ ] Impacts security?
- **Security** - Does the change have a direct security impact on an
application,
    flow, or firmware?
  - Examples: Crypto algorithm change, buffer overflow fix, parameter
    validation improvement, ...
- [ ] Breaking change?
- **Breaking change** - Will anyone consuming this change experience a
break
    in build or boot behavior?
- Examples: Add a new library class, move a module to a different repo,
call
    a function in a new library class in a pre-existing module, ...
- [ ] Includes tests?
  - **Tests** - Does the change include any explicit test code?
  - Examples: Unit tests, integration tests, robot tests, ...
- [ ] Includes documentation?
- **Documentation** - Does the change contain explicit documentation
additions
    outside direct code modifications (and comments)?
- Examples: Update readme file, add feature readme file, link to
documentation
    on an a separate Web page, ...

## How This Was Tested

see #880

## Integration Instructions

N/A
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
impact:non-functional Does not have a functional impact
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants