.github/workflows/publish-qemu-bin.yml: reliability updates #880
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
impact:non-functional
kenlautner
approved these changes
Mar 13, 2024
os-d
approved these changes
Mar 13, 2024
makubacki
approved these changes
Mar 13, 2024
apop5
approved these changes
Mar 13, 2024
Javagedes
force-pushed
the
add-virtio-rom
branch
from
64adbb2
to
c65e970
Compare
Javagedes
added a commit
that referenced
this pull request
Mar 14, 2024
## Description
Update the qemu extdep to the latest mu_tiano_platforms release. This
downgrades qemu to a more reliable version - 7.2.0 and also adds the
following two roms:
- efi-e1000e.rom
- efi-virtio.rom
- [ ] Impacts functionality?
- **Functionality** - Does the change ultimately impact how firmware
functions?
- Examples: Add a new library, publish a new PPI, update an algorithm,
...
- [ ] Impacts security?
- **Security** - Does the change have a direct security impact on an
application,
flow, or firmware?
- Examples: Crypto algorithm change, buffer overflow fix, parameter
validation improvement, ...
- [ ] Breaking change?
- **Breaking change** - Will anyone consuming this change experience a
break
in build or boot behavior?
- Examples: Add a new library class, move a module to a different repo,
call
a function in a new library class in a pre-existing module, ...
- [ ] Includes tests?
- **Tests** - Does the change include any explicit test code?
- Examples: Unit tests, integration tests, robot tests, ...
- [ ] Includes documentation?
- **Documentation** - Does the change contain explicit documentation
additions
outside direct code modifications (and comments)?
- Examples: Update readme file, add feature readme file, link to
documentation
on an a separate Web page, ...
## How This Was Tested
see #880
## Integration Instructions
N/A
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Updates release pipeline for the qemu binary to release qemu v7.2.0 as a external dependency and to also provide the following roms:
efi-e1000e.rom
efi-virtio.rom
Impacts functionality?
Impacts security?
flow, or firmware?
validation improvement, ...
Breaking change?
in build or boot behavior?
a function in a new library class in a pre-existing module, ...
Includes tests?
Includes documentation?
outside direct code modifications (and comments)?
on an a separate Web page, ...
How This Was Tested
Verified Terminal was not in an invalid state after exiting qemu, and that the above roms were successfully found at runtime.
Integration Instructions
Perform a release and update the qemu external dependency inside mu_tiano_platforms