Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade default QEMU to v9.0.0 #901

Merged
merged 9 commits into from
Apr 24, 2024
Merged

Conversation

kuqin12
Copy link
Contributor

@kuqin12 kuqin12 commented Apr 8, 2024

Description

v9.0.0 fixed a few known issues blocking us from upgrading to QEMU of later than v7.2.0.

This change is made to upgrade the default QEMU to v9.0.0 to intake the latest release.

  • Impacts functionality?
    • Functionality - Does the change ultimately impact how firmware functions?
    • Examples: Add a new library, publish a new PPI, update an algorithm, ...
  • Impacts security?
    • Security - Does the change have a direct security impact on an application,
      flow, or firmware?
    • Examples: Crypto algorithm change, buffer overflow fix, parameter
      validation improvement, ...
  • Breaking change?
    • Breaking change - Will anyone consuming this change experience a break
      in build or boot behavior?
    • Examples: Add a new library class, move a module to a different repo, call
      a function in a new library class in a pre-existing module, ...
  • Includes tests?
    • Tests - Does the change include any explicit test code?
    • Examples: Unit tests, integration tests, robot tests, ...
  • Includes documentation?
    • Documentation - Does the change contain explicit documentation additions
      outside direct code modifications (and comments)?
    • Examples: Update readme file, add feature readme file, link to documentation
      on an a separate Web page, ...

How This Was Tested

This change is tested locally on Windows and WSL environment.

Integration Instructions

Existing clones will need to perform PlatformBuild.py --update to download the latest version of QEMU.

@github-actions github-actions bot added language:python Pull requests that update Python code impact:non-functional Does not have a functional impact labels Apr 8, 2024
@kuqin12 kuqin12 marked this pull request as draft April 9, 2024 00:35
@github-actions github-actions bot removed the language:python Pull requests that update Python code label Apr 9, 2024
@Javagedes
Copy link
Contributor

We may want to consider adding a warning to qemu runner if the running version of qemu is less that v9.0.0 that users may experience issues and that they should upgrade to 9.0.0 or greater. Just a thought though.

@kuqin12 kuqin12 marked this pull request as ready for review April 24, 2024 16:55
@kuqin12 kuqin12 merged commit 2ec326c into microsoft:main Apr 24, 2024
33 checks passed
@kuqin12 kuqin12 deleted the then_upgrade_qemu branch April 24, 2024 17:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
impact:non-functional Does not have a functional impact
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants