re-enable debugging for dml#1348
Closed
aciddelgado wants to merge 2 commits intomainfrom
Closed
Conversation
baijumeswani
previously approved these changes
Mar 27, 2025
| // https://github.com/microsoft/onnxruntime/blob/9dbfee91ca9c2ba2074d19805bb6dedccedbcfe3/include/onnxruntime/core/framework/ortdevice.h#L15 | ||
| } else if (memory_info.GetDeviceType() < 5) { | ||
| switch (model.p_device_->GetType()) { | ||
| case DeviceType::CUDA: |
Collaborator
There was a problem hiding this comment.
Shall we try to define a model.p_device_->GetType<std::string>() for each device type? We can avoid the switch statement here then.
stream << model.p_device_->GetType<std::string>() << "\r\n";
Contributor
There was a problem hiding this comment.
I think we can fairly safely say that if the tensor is not on CPU, it's on the model.p_device_
Contributor
There was a problem hiding this comment.
Oh, I see. We shouldn't use a switch here, use this:
std::string to_string(DeviceType device_type);
Collaborator
|
i believe this change might have been reverted in ort. closing this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
this was removed in a prior change.