Update iOS LLM Application #505
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
vraspar
commented
Dec 18, 2024
vraspar
commented
- Update App to use new GenAI API
- Add ability to select model path from app to allow using multiple models in single build
vraspar
force-pushed
the
vraspar/llm-ios-app-update
branch
from
a6c98fc to
6102533
Compare
vraspar
commented
Dec 18, 2024
There was a problem hiding this comment.
Copilot reviewed 3 out of 7 changed files in this pull request and generated no comments.
Files not reviewed (4)
- mobile/examples/phi-3/ios/LocalLLM/LocalLLM/ContentView.swift: Language not supported
- mobile/examples/phi-3/ios/LocalLLM/LocalLLM/FolderPicker.swift: Language not supported
- mobile/examples/phi-3/ios/LocalLLM/LocalLLM/GenAIGenerator.h: Language not supported
- mobile/examples/phi-3/ios/LocalLLM/LocalLLM/GenAIGenerator.mm: Language not supported
edgchen1
reviewed
Apr 16, 2025
| @@ -405,8 +422,10 @@ | |||
| "$(PROJECT_DIR)/LocalLLM/lib", | |||
| ); | |||
| MARKETING_VERSION = 1.0; | |||
| PRODUCT_BUNDLE_IDENTIFIER = ai.onnxruntime.genai.demo.LocalLLM; | |||
| "MTL_ENABLE_DEBUG_INFO[sdk=iphoneos*]" = ""; | |||
| PRODUCT_BUNDLE_IDENTIFIER = ai.onnxruntime.genai.demo.LocalLL; | |||
There was a problem hiding this comment.
is the change to PRODUCT_BUNDLE_IDENTIFIER intentional? also on line 471.
There was a problem hiding this comment.
do we need the onnxruntime header? it looks like GenAIGenerator.mm only uses the onnxruntime-genai headers.
| @@ -7,12 +7,12 @@ | |||
| #include "ort_genai.h" | |||
| #include "ort_genai_c.h" | |||
|
|
|||
|
|
|||
| const size_t kMaxTokens = 200; | |||
| const size_t kMaxTokens = 64; | |||
| @synchronized(self) { | ||
| self->modelPath = [modelPath copy]; | ||
| NSLog(@"Model folder path set to: %@", modelPath); | ||
| [self loadModelFromPath]; |
There was a problem hiding this comment.
should we ensure that C++ exceptions don't leave this scope?
|
|
||
| auto generator = OgaGenerator::Create(*self->model, *params); | ||
|
|
||
| bool isFirstToken = true; | ||
| NSLog(@"Starting token generation loop..."); | ||
|
|
||
| startTime = Clock::now(); | ||
| firstTokenTime = Clock::now(); |
There was a problem hiding this comment.
why set it to the current time?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.