More detailed comments and camelCases

microsoft · Oct 24, 2024 · 238adb0 · 238adb0
1 parent ec748ce
commit 238adb0
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 6 deletions.
diff --git a/js/scripts/utils.ts b/js/scripts/utils.ts
@@ -2,12 +2,14 @@
 // Licensed under the MIT License.
 
 import { WriteStream } from 'fs';
-import {bootstrap as global_agent_bootstrap} from 'global-agent';
+import { bootstrap as globalAgentBootstrap } from 'global-agent';
 import * as https from 'https';
 import { JSZipObject } from 'jszip';
 
-// Bootstrap global-agent to honor the proxy settings
-global_agent_bootstrap();
+// Bootstrap global-agent to honor the proxy settings in
+// environment variables, e.g. GLOBAL_AGENT_HTTPS_PROXY.
+// See https://github.com/gajus/global-agent/blob/v3.0.0/README.md#environment-variables for details.
+globalAgentBootstrap();
 
 export const downloadZip = async (url: string): Promise<Buffer> =>
   new Promise<Buffer>((resolve, reject) => {

diff --git a/js/web/script/pull-prebuilt-wasm-artifacts.ts b/js/web/script/pull-prebuilt-wasm-artifacts.ts
@@ -14,7 +14,7 @@
 //
 
 import fs from 'fs';
-import {bootstrap as global_agent_bootstrap} from 'global-agent';
+import { bootstrap as globalAgentBootstrap } from 'global-agent';
 import https from 'https';
 import jszip from 'jszip';
 import path from 'path';
@@ -112,8 +112,10 @@ console.log(
   } ===`,
 );
 
-// Bootstrap global-agent to honor the proxy settings
-global_agent_bootstrap();
+// Bootstrap global-agent to honor the proxy settings in
+// environment variables, e.g. GLOBAL_AGENT_HTTPS_PROXY.
+// See https://github.com/gajus/global-agent/blob/v3.0.0/README.md#environment-variables for details.
+globalAgentBootstrap();
 
 const filter = buildId
   ? `&buildIds=${buildId}`