-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support xcframework for mac catalyst builds. #19534
Conversation
…yguo/maccatalyst-build-ios-package
Still addressing a couple build failures and need to figure out a test for catalyst variant on the pipeline. |
Co-authored-by: Scott McKay <[email protected]>
/azp run Windows GPU TensorRT CI Pipeline,onnxruntime-binary-size-checks-ci-pipeline,iOS CI Pipeline,ONNX Runtime React Native CI Pipeline |
/azp run Linux CPU Minimal Build E2E CI Pipeline |
Azure Pipelines successfully started running 4 pipeline(s). |
Azure Pipelines successfully started running 1 pipeline(s). |
I know this is Work in Progress, but I'd love to get some usage instructions on how to compile this. I have managed to build a native framework, but I'm a bit lost on the invocations needed to build an ARM64 one, and also joining them together into a (preferably static) dual-architecture PS. This branch/pull request alone saves us so much work it's hard to express in words. ❤️ |
thanks for the feedback! Regarding the question, if you would run the command as something like
And you can always adjust the build settings with the desired architectures (x86_64 or arm64)/ deployment target version via editing this config here: https://github.com/microsoft/onnxruntime/blob/bff4f8bf75562704720624fac63b149d10042ac8/tools/ci_build/github/apple/default_full_ios_framework_build_settings.json |
I was about to submit a bug report about missing symbols but you fixed it already via 1629aa9. :) Once again, thank you so so much - you removed a gigantic roadblock in our project. :) |
/azp run Windows GPU TensorRT CI Pipeline,onnxruntime-binary-size-checks-ci-pipeline,iOS CI Pipeline,ONNX Runtime React Native CI Pipeline |
/azp run Linux CPU Minimal Build E2E CI Pipeline |
Azure Pipelines successfully started running 4 pipeline(s). |
Azure Pipelines successfully started running 1 pipeline(s). |
…yguo/maccatalyst-build-ios-package
### Description <!-- Describe your changes. --> ### Motivation and Context <!-- - Why is this change required? What problem does it solve? - If it fixes an open issue, please link to the issue here. --> MAUI on macOS uses mac-catalyst which requires a different native binary. --------- Co-authored-by: rachguo <[email protected]> Co-authored-by: Scott McKay <[email protected]>
Description
Motivation and Context
MAUI on macOS uses mac-catalyst which requires a different native binary.