Extend DoubleQDQPairsRemover to handle sequences that end in duplicate DQ nodes #20759
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adrianlizarraga
changed the title
adrianlizarraga
requested review from
jchen351,
yufenglee,
skottmckay,
jywu-msft and
HectorSVC
adrianlizarraga
commented
May 23, 2024
yuslepukhin
previously requested changes
May 23, 2024
edgchen1
reviewed
May 24, 2024
Co-authored-by: Edward Chen <[email protected]>
|
@yuslepukhin I addressed your comments. Could you please take another look? Merging is blocked on Github until you approve that your requested changes have been addressed. |
jywu-msft
dismissed
yuslepukhin’s stale review
adrian addressed comments already. need to unblock this merge.
jywu-msft
approved these changes
May 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Extend the DoubleQDQPairsRemover optimizer to also handle sequences that end in duplicate DQ nodes.
For example, the following sequence:
Is now simplified to:
Motivation and Context
The EnsureUniqueDQNodeUnits pass may add duplicate DQ nodes to ensure valid QDQ node units. The DoubleQDQPairsRemover should still be able to remove unnecessary QDQ ops if the target sequence ends in duplicate DQ nodes.