Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added requested install instructions to ORT ROCm Python. #21124

Merged
merged 4 commits into from
Jul 8, 2024
Merged

Added requested install instructions to ORT ROCm Python. #21124

merged 4 commits into from
Jul 8, 2024

Conversation

MaanavD
Copy link
Contributor

@MaanavD MaanavD commented Jun 20, 2024

To close: #21036

@MaanavD MaanavD requested review from natke and sophies927 June 20, 2024 22:34
@MaanavD
Copy link
Contributor Author

MaanavD commented Jun 20, 2024

Preview is found here: https://maanavd.github.io/onnxruntime/docs/install/#python-installs

tianleiwu
tianleiwu reviewed Jun 20, 2024
View reviewed changes
docs/install/index.md Outdated Show resolved Hide resolved
@tianleiwu
Copy link
Contributor

In https://onnxruntime.ai/docs/execution-providers/ROCm-ExecutionProvider.html
I saw a sentence like Pre-built binaries of ONNX Runtime with ROCm EP are published for most language bindings..
If we do not have pre-built binaries for ROCm, that need change as well.

natke
natke reviewed Jun 20, 2024
View reviewed changes
Copy link
Contributor

@natke natke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we add the install changes to the install table too?

tianleiwu
tianleiwu reviewed Jun 20, 2024
View reviewed changes
docs/install/index.md Outdated Show resolved Hide resolved
tianleiwu
tianleiwu reviewed Jun 27, 2024
View reviewed changes
docs/install/index.md Outdated Show resolved Hide resolved
@MaanavD
Copy link
Contributor Author

MaanavD commented Jul 8, 2024

@tianleiwu is this phrasing better? (If not, could you suggest the changes yourself to what you think is best?)

@MaanavD MaanavD merged commit 8c073f9 into microsoft:gh-pages Jul 8, 2024
7 checks passed
@MaanavD MaanavD deleted the rocm_install_update branch July 8, 2024 20:27
@MaanavD MaanavD mentioned this pull request Aug 16, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@natke natke natke left review comments

@tianleiwu tianleiwu tianleiwu approved these changes

@sophies927 sophies927 Awaiting requested review from sophies927

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@MaanavD @tianleiwu @natke