Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use the scalar MlasSgemm CopyPackB and TransposePackB implementation for RISCV and Update activation test compare check to include NaN case #21261

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

KaustubhIMG
Copy link

Add new define MLAS_TARGET_RISCV under _M_RISCV or __riscv.
Add MLAS_TARGET_RISCV in check across MlasSgemmCopyPackB and MlasSgemmTransposePackB implementation to use 4 wide packing functions.

For RISCV, the MlasSgemmKernel is used which has packing wide of 4. The default MlasSgemmCopyPackB (which was under just !defined(MLAS_TARGET_WASM_SCALAR) chack) has packing width of 16, causing the tests to mismatch.

…ntation for RISCV

Add new define MLAS_TARGET_RISCV under _M_RISCV or __riscv. Add MLAS_TARGET_RISCV in check across MlasSgemmCopyPackB and MlasSgemmTransposePackB implementation.
@KaustubhIMG KaustubhIMG requested a review from a team as a code owner July 5, 2024 12:14
@KaustubhIMG
Copy link
Author

@microsoft-github-policy-service agree [company="{Imagination Technologies}"]

@KaustubhIMG
Copy link
Author

@microsoft-github-policy-service agree company="Imagination Technologies"

@yufenglee
Copy link
Member

/azp run Windows ARM64 QNN CI Pipeline,Windows x64 QNN CI Pipeline,Windows CPU CI Pipeline,Windows GPU CI Pipeline,Windows GPU TensorRT CI Pipeline,ONNX Runtime Web CI Pipeline,Linux CPU CI Pipeline,Linux CPU Minimal Build E2E CI Pipeline,Linux GPU CI Pipeline,Linux GPU TensorRT CI Pipeline

@yufenglee
Copy link
Member

/azp run Linux OpenVINO CI Pipeline,Linux QNN CI Pipeline,MacOS CI Pipeline,orttraining-amd-gpu-ci-pipeline,orttraining-linux-ci-pipeline,orttraining-linux-gpu-ci-pipeline,orttraining-ortmodule-distributed,onnxruntime-binary-size-checks-ci-pipeline,Big Models,Linux Android Emulator QNN CI Pipeline

@yufenglee
Copy link
Member

/azp run Android CI Pipeline,iOS CI Pipeline,ONNX Runtime React Native CI Pipeline

@KaustubhIMG
Copy link
Author

@yufenglee Can you review the changes?

@KaustubhIMG KaustubhIMG changed the title Use the scalar MlasSgemm CopyPackB and TransposePackB implementation for RISCV Use the scalar MlasSgemm CopyPackB and TransposePackB implementation for RISCV and Update activation test compare check to include NaN case Sep 16, 2024
@yufenglee
Copy link
Member

/azp run Windows ARM64 QNN CI Pipeline,Windows x64 QNN CI Pipeline,Windows CPU CI Pipeline,Windows GPU CI Pipeline,Windows GPU TensorRT CI Pipeline,ONNX Runtime Web CI Pipeline,Linux CPU CI Pipeline,Linux CPU Minimal Build E2E CI Pipeline,Linux GPU CI Pipeline,Linux GPU TensorRT CI Pipeline

@yufenglee
Copy link
Member

/azp run Linux OpenVINO CI Pipeline,Linux QNN CI Pipeline,MacOS CI Pipeline,orttraining-amd-gpu-ci-pipeline,orttraining-linux-ci-pipeline,orttraining-linux-gpu-ci-pipeline,orttraining-ortmodule-distributed,onnxruntime-binary-size-checks-ci-pipeline,Big Models,Linux Android Emulator QNN CI Pipeline

@yufenglee
Copy link
Member

/azp run Android CI Pipeline,iOS CI Pipeline,ONNX Runtime React Native CI Pipeline

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants