[Fix] Exception in iosDynamicFramework Post-Merge workflow #21262

mszhanyi · 2024-07-05T12:35:56Z

Description

the exception was caused by 3dd6fcc

Why I add skip_macos_test
because there's new an exception in https://dev.azure.com/onnxruntime/onnxruntime/_build/results?buildId=1425579&view=logs&j=c90c5af3-67d5-5936-5a62-71c93ebfca65&t=01038f35-8e78-5801-1aa1-d9647bb65858

2024-07-05T14:41:09.3864740Z mkdir -p /Users/runner/Library/Developer/Xcode/DerivedData/apple_package_test-akksnidsbpojopfdqrclgsoqqerv/Build/Products/Debug/macos_package_testUITests.xctest/Contents/Frameworks
2024-07-05T14:41:09.3933430Z mkdir: /Users/runner/Library/Developer/Xcode/DerivedData/apple_package_test-akksnidsbpojopfdqrclgsoqqerv/Build/Products/Debug/macos_package_testUITests.xctest: Operation not permitted
2024-07-05T14:41:09.3996760Z /var/folders/0f/b0mzpg5d31z074x3z5lzkdxc0000gn/T/tmp97ycvwq5/apple_package_test/Pods/Target Support Files/Pods-macos_package_testUITests/Pods-macos_package_testUITests-frameworks.sh: line 7: realpath: command not found
2024-07-05T14:41:09.4003170Z :18: error: Unexpected failure
2024-07-05T14:41:11.1323470Z error: Sandbox: mkdir(72212) deny(1) file-write-create /Users/runner/Library/Developer/Xcode/DerivedData/apple_package_test-akksnidsbpojopfdqrclgsoqqerv/Build/Products/Debug/macos_package_testUITests.xctest (in target 'macos_package_testUITests' from project 'apple_package_test')
2024-07-05T14:41:11.1325620Z 
2024-07-05T14:41:11.8731110Z 
2024-07-05T14:41:11.8733040Z Test session results, code coverage, and logs:
2024-07-05T14:41:11.8734820Z 	/Users/runner/Library/Developer/Xcode/DerivedData/apple_package_test-akksnidsbpojopfdqrclgsoqqerv/Logs/Test/Test-macos_package_test-2024.07.05_14-40-38-+0000.xcresult
2024-07-05T14:41:11.8735530Z 
2024-07-05T14:41:11.8906210Z Testing failed:
2024-07-05T14:41:11.8911060Z 	Sandbox: mkdir(72212) deny(1) file-write-create /Users/runner/Library/Developer/Xcode/DerivedData/apple_package_test-akksnidsbpojopfdqrclgsoqqerv/Build/Products/Debug/macos_package_testUITests.xctest
2024-07-05T14:41:11.8912570Z 	Unexpected failure
2024-07-05T14:41:11.8913690Z 	Testing cancelled because the build failed.
2024-07-05T14:41:11.8914380Z 
2024-07-05T14:41:11.8914970Z ** TEST FAILED **
2024-07-05T14:41:11.8915480Z 
2024-07-05T14:41:11.8915780Z 
2024-07-05T14:41:11.8916750Z The following build commands failed:
2024-07-05T14:41:11.8919280Z 	PhaseScriptExecution [CP]\ Embed\ Pods\ Frameworks /Users/runner/Library/Developer/Xcode/DerivedData/apple_package_test-akksnidsbpojopfdqrclgsoqqerv/Build/Intermediates.noindex/apple_package_test.build/Debug/macos_package_testUITests.build/Script-059136A7770CA5376C30F2FD.sh (in target 'macos_package_testUITests' from project 'apple_package_test')
2024-07-05T14:41:11.8922180Z (1 failure)

And I find macos test is skipped in

onnxruntime/tools/ci_build/github/azure-pipelines/templates/c-api-cpu.yml

Lines 119 to 127 in 9ef28f0

    
               - script: | 
        
                   python3 tools/ci_build/github/apple/test_apple_packages.py \ 
        
                     --fail_if_cocoapods_missing \ 
        
                     --framework_info_file "$(Build.BinariesDirectory)/ios_framework/xcframework_info.json" \ 
        
                     --c_framework_dir "$(Build.BinariesDirectory)/ios_framework/framework_out" \ 
        
                     --variant Full \ 
        
                     --skip_macos_test \ 
        
                     --mac_catalyst_enabled 
        
                 displayName: "Test Apple framework"

as well.
Maybe it is an known issue.

Motivation and Context

This reverts commit 800ea89.

…zhanyi/postios

onnxruntime/test/platform/apple/apple_package_test/Podfile.template

edgchen1 · 2024-07-05T17:46:24Z

And I find macos test is skipped in

onnxruntime/tools/ci_build/github/azure-pipelines/templates/c-api-cpu.yml

Lines 119 to 127 in 9ef28f0

- script: |

python3 tools/ci_build/github/apple/test_apple_packages.py \

--fail_if_cocoapods_missing \

--framework_info_file "$(Build.BinariesDirectory)/ios_framework/xcframework_info.json" \

--c_framework_dir "$(Build.BinariesDirectory)/ios_framework/framework_out" \

--variant Full \

--skip_macos_test \

--mac_catalyst_enabled

displayName: "Test Apple framework"

as well.
Maybe it is an known issue.

It's skipped there because that build doesn't include a MacOS framework.

onnxruntime/tools/ci_build/github/azure-pipelines/templates/c-api-cpu.yml

Lines 106 to 108 in 9ef28f0

    
                   python3 tools/ci_build/github/apple/build_apple_framework.py \ 
        
                     --build_dir "$(Build.BinariesDirectory)/ios_framework" \ 
        
                     tools/ci_build/github/apple/default_full_ios_framework_build_settings.json

See the build settings file:
https://github.com/microsoft/onnxruntime/blob/9ef28f092f575ce15bfc40c7663e649e75809c53/tools/ci_build/github/apple/default_full_ios_framework_build_settings.json

This one does:

onnxruntime/tools/ci_build/github/azure-pipelines/post-merge-jobs.yml

Lines 446 to 449 in 9ef28f0

    
                   python tools/ci_build/github/apple/build_apple_framework.py \ 
        
                     --build_dir "$(Build.BinariesDirectory)/ios_framework" \ 
        
                     --build_dynamic_framework \ 
        
                     tools/ci_build/github/apple/default_full_apple_framework_build_settings.json

https://github.com/microsoft/onnxruntime/blob/9ef28f092f575ce15bfc40c7663e649e75809c53/tools/ci_build/github/apple/default_full_apple_framework_build_settings.json

snnn · 2024-07-08T12:41:47Z

 line 7: realpath: command not found

Why do we have this error? Which bash script it was executing?

mszhanyi · 2024-07-09T07:07:33Z

I installed realpath in MacOS, but there's still exceptions that
https://dev.azure.com/onnxruntime/onnxruntime/_build/results?buildId=1425914&view=results
mkdir -p /Users/runner/Library/Developer/Xcode/DerivedData/apple_package_test-czndqrumonhwrcfnzjpzvusppkaz/Build/Products/Debug/macos_package_testUITests.xctest/Contents/Frameworks
mkdir: /Users/runner/Library/Developer/Xcode/DerivedData/apple_package_test-czndqrumonhwrcfnzjpzvusppkaz/Build/Products/Debug/macos_package_testUITests.xctest: Operation not permitted
@edgchen1 do you know where the mkdir is called. I don't find it in the repo.

And I'm a little confused that why there's macOS since the stage name is called iosDynamicFramewok

edgchen1 · 2024-07-09T22:28:47Z

@edgchen1 do you know where the mkdir is called. I don't find it in the repo.

mkdir -p /Users/runner/Library/Developer/Xcode/DerivedData/apple_package_test-czndqrumonhwrcfnzjpzvusppkaz/Build/Products/Debug/macos_package_testUITests.xctest/Contents/Frameworks
mkdir: /Users/runner/Library/Developer/Xcode/DerivedData/apple_package_test-czndqrumonhwrcfnzjpzvusppkaz/Build/Products/Debug/macos_package_testUITests.xctest: Operation not permitted
/private/var/folders/0f/b0mzpg5d31z074x3z5lzkdxc0000gn/T/tmpl8pn_rhn/apple_package_test/Pods/Target Support Files/Pods-macos_package_testUITests/Pods-macos_package_testUITests-frameworks.sh:18: error: Unexpected failure

This Pods-macos_package_testUITests-frameworks.sh script looks like some generated CocoaPods thing.

And I'm a little confused that why there's macOS since the stage name is called iosDynamicFramewok

That's a good point. This was changed in #20773. It used to point to an iOS-only build settings file but that one got deleted.

It might be simpler to change it back to an iOS-only build for now. It looks like there are other things to fix for MacOS.

I think tools/ci_build/github/apple/default_full_ios_framework_build_settings.json is too heavy as it has quite a few sysroot/arch combinations. E.g., we could use another one which only builds iphonesimulator/x86_64.

…nto zhanyi/postios

mszhanyi · 2024-07-11T07:20:34Z

Since we need other things to fix for MacOS, I add a new setting files only for iOS and skip macos test that the pipeline can pass.
https://dev.azure.com/onnxruntime/onnxruntime/_build/results?buildId=1429950&view=results

tools/ci_build/github/apple/build_apple_framework.py

tools/ci_build/github/azure-pipelines/post-merge-jobs.yml

Yi Zhang and others added 10 commits July 1, 2024 11:54

readd mobile json

58c9cc4

rm disable exception

5f2bc50

test full

cda7291

osx 13.0

f2413e5

skip macos test

1ada11b

only build macabi x86_64

7ac1677

update

800ea89

macabi arm64

8cdac62

Revert "update"

d8a31e5

This reverts commit 800ea89.

update build dir

f712135

mszhanyi requested a review from a team as a code owner July 5, 2024 12:35

update

d96b981

mszhanyi requested a review from skottmckay July 5, 2024 15:25

Merge branch 'main' of https://github.com/microsoft/onnxruntime into …

3068992

…zhanyi/postios

edgchen1 reviewed Jul 5, 2024

View reviewed changes

onnxruntime/test/platform/apple/apple_package_test/Podfile.template Outdated Show resolved Hide resolved

mszhanyi and others added 2 commits July 7, 2024 20:36

update as comments

75e89a8

install realpath in mac

1b960d4

mszhanyi force-pushed the zhanyi/postios branch from 9f58112 to 1b960d4 Compare July 8, 2024 08:41

pavangoyal42 mentioned this pull request Jul 8, 2024

[Fix] InterOpNumThreads Session Option for ONNX ReactNative Package #21263

Merged

Yi Zhang added 2 commits July 11, 2024 10:01

Merge branch 'main' of https://www.github.com/microsoft/onnxruntime i…

60d21c9

…nto zhanyi/postios

reuse mobile ios build settings

01e02a8

mszhanyi force-pushed the zhanyi/postios branch from 34df650 to 01e02a8 Compare July 11, 2024 02:19

Yi Zhang added 2 commits July 11, 2024 10:48

update

857dcf1

typo

ffda7e8

mszhanyi force-pushed the zhanyi/postios branch from ea36c84 to ffda7e8 Compare July 11, 2024 02:59

skip macos test

2cc99b1

edgchen1 reviewed Jul 11, 2024

View reviewed changes

tools/ci_build/github/apple/build_apple_framework.py Outdated Show resolved Hide resolved

edgchen1 reviewed Jul 11, 2024

View reviewed changes

tools/ci_build/github/azure-pipelines/post-merge-jobs.yml Outdated Show resolved Hide resolved

edgchen1 reviewed Jul 11, 2024

View reviewed changes

tools/ci_build/github/azure-pipelines/post-merge-jobs.yml Outdated Show resolved Hide resolved

roll back some changes

e0ae81d

mszhanyi requested a review from edgchen1 July 12, 2024 00:00

edgchen1 approved these changes Jul 12, 2024

View reviewed changes

snnn approved these changes Jul 12, 2024

View reviewed changes

snnn merged commit f2ebd1c into main Jul 12, 2024
98 of 101 checks passed

snnn deleted the zhanyi/postios branch July 12, 2024 16:24

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Fix] Exception in iosDynamicFramework Post-Merge workflow #21262

[Fix] Exception in iosDynamicFramework Post-Merge workflow #21262

mszhanyi commented Jul 5, 2024 •

edited

Loading

edgchen1 commented Jul 5, 2024

snnn commented Jul 8, 2024

mszhanyi commented Jul 9, 2024

edgchen1 commented Jul 9, 2024

mszhanyi commented Jul 11, 2024 •

edited

Loading

	- script: \|
	python3 tools/ci_build/github/apple/test_apple_packages.py \
	--fail_if_cocoapods_missing \
	--framework_info_file "$(Build.BinariesDirectory)/ios_framework/xcframework_info.json" \
	--c_framework_dir "$(Build.BinariesDirectory)/ios_framework/framework_out" \
	--variant Full \
	--skip_macos_test \
	--mac_catalyst_enabled
	displayName: "Test Apple framework"

[Fix] Exception in iosDynamicFramework Post-Merge workflow #21262

[Fix] Exception in iosDynamicFramework Post-Merge workflow #21262

Conversation

mszhanyi commented Jul 5, 2024 • edited Loading

Description

Motivation and Context

edgchen1 commented Jul 5, 2024

snnn commented Jul 8, 2024

mszhanyi commented Jul 9, 2024

edgchen1 commented Jul 9, 2024

mszhanyi commented Jul 11, 2024 • edited Loading

mszhanyi commented Jul 5, 2024 •

edited

Loading

mszhanyi commented Jul 11, 2024 •

edited

Loading