Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade XNNPACK to latest version #22012

Merged
merged 27 commits into from
Sep 17, 2024
Merged

Upgrade XNNPACK to latest version #22012

merged 27 commits into from
Sep 17, 2024

Conversation

mszhanyi
Copy link
Contributor

@mszhanyi mszhanyi commented Sep 6, 2024 •
edited
Loading

Description

Update XNNPack to latest version (Sep 4)

  • Some op outputs are changed, channel or stride paras are moved into reshape func.
    e.g. google/XNNPACK@96962a6
  • input params of xnnpack's resize related function are changed a lot
  • KleidiAI is added as a dependency in ARM64
  • The latest XNNPACK includes 2 static libs microkernels-prod and xnnpack.
    Without microkernels-prod, it throws the exception of Undefined symbols.
  • Add ORT_TARGET_PROCESSOR to get the real processor target in CMake

Motivation and Context

@mszhanyi mszhanyi requested review from a team as code owners September 6, 2024 07:29
@mszhanyi mszhanyi marked this pull request as draft September 6, 2024 07:29
@mszhanyi mszhanyi requested a review from skottmckay September 6, 2024 07:48
@mszhanyi mszhanyi force-pushed the zhanyi/upgradexnn branch 2 times, most recently from 5e9f59a to 1c0f420 Compare September 13, 2024 15:01
@mszhanyi mszhanyi marked this pull request as ready for review September 14, 2024 15:03
snnn
snnn previously approved these changes Sep 14, 2024
View reviewed changes
skottmckay
skottmckay reviewed Sep 15, 2024
View reviewed changes
cmake/external/xnnpack.cmake Outdated Show resolved Hide resolved
onnxruntime/core/providers/xnnpack/math/softmax.cc Outdated Show resolved Hide resolved
snnn
snnn previously approved these changes Sep 16, 2024
View reviewed changes
@mszhanyi mszhanyi requested a review from skottmckay September 17, 2024 05:16
skottmckay
skottmckay previously approved these changes Sep 17, 2024
View reviewed changes
cmake/external/xnnpack.cmake Outdated Show resolved Hide resolved
cmake/external/xnnpack.cmake Show resolved Hide resolved
@mszhanyi
Copy link
Contributor Author

@pranavsharma

@mszhanyi mszhanyi requested review from skottmckay and snnn September 17, 2024 14:26
@snnn snnn merged commit b94ba09 into main Sep 17, 2024
145 checks passed
@snnn snnn deleted the zhanyi/upgradexnn branch September 17, 2024 17:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pranavsharma pranavsharma pranavsharma approved these changes

@snnn snnn snnn approved these changes

@skottmckay skottmckay Awaiting requested review from skottmckay

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mszhanyi @snnn @skottmckay @pranavsharma