[TensorRT EP] Refactor TRT version update logic & apply TRT 10.5 #22483
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
read variables by py-win-gpu
chilo-ms
reviewed
Oct 23, 2024
|
Looks good to me, please help resolve the conflicts. |
chilo-ms
previously approved these changes
Oct 25, 2024
chilo-ms
approved these changes
Oct 28, 2024
jywu-msft
approved these changes
Oct 29, 2024
|
@yf711 just realized we forgot to update oss parser branch to https://github.com/onnx/onnx-tensorrt/tree/10.5-GA-ORT-DDS |
will send out PR later today |
PR to update oss parser branch: #22644 |
ishwar-raut1
pushed a commit
to ishwar-raut1/onnxruntime
that referenced
this pull request
Nov 19, 2024
…rosoft#22483) ### Description <!-- Describe your changes. --> * Leverage template `common-variables.yml` and reduce usage of hardcoded trt_version https://github.com/microsoft/onnxruntime/blob/8391b24447fcca4c01599b3270255fbf76ac8a21/tools/ci_build/github/azure-pipelines/templates/common-variables.yml#L2-L7 * Among all CI yamls, this PR reduces usage of hardcoding trt_version from 40 to 6, by importing trt_version from `common-variables.yml` * Apply TRT 10.5 and re-enable control flow op test ### Motivation and Context <!-- - Why is this change required? What problem does it solve? - If it fixes an open issue, please link to the issue here. --> - Reduce usage of hardcoding trt_version among all CI ymls ### Next refactor PR will work on reducing usage of hardcoding trt_version among `.dockerfile`, `.bat` and remaining 2 yml files (download_win_gpu_library.yml & set-winenv.yml, which are step-template yaml that can't import variables)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
common-variables.ymland reduce usage of hardcoded trt_versiononnxruntime/tools/ci_build/github/azure-pipelines/templates/common-variables.yml
Lines 2 to 7 in 8391b24
common-variables.ymlMotivation and Context
Next refactor PR
will work on reducing usage of hardcoding trt_version among
.dockerfile,.batand remaining 2 yml files(download_win_gpu_library.yml & set-winenv.yml, which are step-template yaml that can't import variables)