Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Ignite to events, updating qualcomm onnx models. #22564

Merged
merged 2 commits into from
Oct 25, 2024

Conversation

MaanavD
Copy link
Contributor

@MaanavD MaanavD commented Oct 23, 2024

Copy link
Contributor

@sophies927 sophies927 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For the Events page, I have a couple suggestions:

  1. I think it would be good to change the title to something like "ONNX Runtime at Microsoft Ignite Conference" and then making the blurb more focused on the ORT content that will be covered (instead of using the description from Ignite as a whole).
  2. To that same effect, change the button from "Event Page" to "Microsoft Ignite Page".
  3. For me, the image for the Ignite section is showing up as the same image used for the ONNX Community Meetup:
    image
    I think it would be good to use another image.

Copy link
Contributor

@sophies927 sophies927 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For the Models page, I think it would be good to have more specific distinctions between each of the categories, particularly the ones on Hugging Face. Right now, it's not really coming across why someone would use one vs. another / what the difference is.

Also, this is super nit-picky, but Hugging Face has a space in it (not HuggingFace).

For example:

  1. ONNX Community (hosted on Hugging Face): Access, share, and discuss ONNX models published to Hugging Face by members of the ONNX Community.
  2. ONNX Model Zoo (hosted on ONNX website): Explore pre-trained ONNX models curated by the ONNX community.
  3. Qualcomm ONNX Models (hosted on Hugging Face): Discover ONNX-compatible models optimized for Qualcomm hardware on Hugging Face.
    Then you can add a line after these 3 sections to the effect of "Access all ONNX models available on the Hugging Face Model Hub here." (The ONNX Model Zoo does the same: https://onnx.ai/models/.)

Copy link
Contributor

@sophies927 sophies927 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@MaanavD MaanavD merged commit 5775e39 into microsoft:gh-pages Oct 25, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants