Refactor SkipLayerNorm and handle beta properly #22862
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Liqun Fu <[email protected]>
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
amarin16
reviewed
Nov 16, 2024
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Signed-off-by: Liqun Fu <[email protected]>
amarin16
reviewed
Nov 16, 2024
amarin16
previously approved these changes
Nov 16, 2024
sophies927
added
triage:approved
amarin16
reviewed
Nov 16, 2024
|
Do we have unit test cover this? |
liqunfu
changed the title
Signed-off-by: Liqun Fu <[email protected]>
Not with this PR, shall add test cases in a different PR. Need to merge EOD so not to block the release. |
Signed-off-by: Liqun Fu <[email protected]>
amarin16
previously approved these changes
Nov 17, 2024
Signed-off-by: Liqun Fu <[email protected]>
jywu-msft
approved these changes
Nov 17, 2024
yf711
pushed a commit
that referenced
this pull request
Nov 18, 2024
Signed-off-by: Liqun Fu <[email protected]> Signed-off-by: Liqun Fu <[email protected]> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
ishwar-raut1
pushed a commit
to ishwar-raut1/onnxruntime
that referenced
this pull request
Nov 19, 2024
Signed-off-by: Liqun Fu <[email protected]> Signed-off-by: Liqun Fu <[email protected]> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
yf711
added a commit
that referenced
this pull request
Nov 19, 2024
### Description <!-- Describe your changes. --> All three PRs are cherry-picked in this round: 1. [Refactor SkipLayerNorm and handle beta properly (#22862) ](#22862) 2. [[TensorRT EP] Exclude DDS ops from running on TRT (#22875)](#22875) 3. [[QNN EP] QNN SDK 2.28.2 (#22844) ](#22844) ### Motivation and Context <!-- - Why is this change required? What problem does it solve? - If it fixes an open issue, please link to the issue here. --> --------- Signed-off-by: Liqun Fu <[email protected]> Signed-off-by: Liqun Fu <[email protected]> Co-authored-by: Chi Lo <[email protected]> Co-authored-by: liqun Fu <[email protected]> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Adrian Lizarraga <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.