-
Notifications
You must be signed in to change notification settings - Fork 3.7k
Graphics ORT interop design and implementation #26543
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
praneshgo
wants to merge
21
commits into
microsoft:main
Choose a base branch
from
praneshgo:pgonegandla/graphics_ort_interop
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Changes from 19 commits
Commits
Show all changes
21 commits
Select commit
Hold shift + click to select a range
5dce33a
Graphics ORT Interop related changes
praneshgo b65c59e
Adding a few fixes based on CodeRabbit's review comments
praneshgo 36f6130
Few bug fixes in the fall back path and a API linking issue fix
praneshgo db281b5
Adding additional compile parameter and macro for DX interop
praneshgo 36086b5
Added documentation for APIs, modified the error handling in EpSignal…
praneshgo 9830d42
Adding Vulkan compilation support, adding more members to GraphicsInt…
praneshgo d032260
Adding CIG support for DX
praneshgo 0432087
Not looping for EPs in InteropWait and InteropSignal calls
praneshgo 49549bf
FenceInteropParams moved out of GraphicsInteropParams; SemaphoreEpMap…
praneshgo 8931f16
A few code fixes, highlighted by CodeRabbit
praneshgo cb90d98
Fixing windows_nvtensorrtrtx_build and build_linux_nv_only pipelines
praneshgo 0861626
Adding a small fix to further get build-linux-nv-only pipeline to pass
praneshgo 21697fa
A few parameter level changes that do not change the functionality much
praneshgo a42b35e
Moving newly added APIs to the end to avoid ABI breakage
praneshgo c3e7886
Not exposing DX/Vulkan datatypes and headers in public ORT headers
praneshgo ad61f8c
Merge remote-tracking branch 'origin/main' into pgonegandla/graphics_…
praneshgo 8d7a5c8
Couple of tiny fixes
praneshgo 613ffbf
Adding sample test that demonstrates DX-ORT interop feature with NV T…
praneshgo 9d1f961
Update nv_basic_ort_interop_test.cc
praneshgo 3e30712
[1/n] Addressing a few comments - Renaming APIs to make them seem mor…
praneshgo 23dac57
[2/n] Addressing review comments
praneshgo File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
IExecutionProvider is an internal type. As such I wouldn't expect it's API to be using things like
void** extSemFenceas conversion from opaque API types to the 'real' internal types should be handled by thePluginExecutionProviderclass which implements IExecutionProvider for plugin EPs.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That makes sense. I will modify the code in the next commit based on this suggestion.