-
Notifications
You must be signed in to change notification settings - Fork 3.7k
Integration with ONNX==1.20.1 #26579
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
There appears to be a gap in the vcpkg configuration for native Linux builds regarding the protobuf library version. The generated triplet file (e.g., This is because the logic in if is_emscripten:
# Uses ONNX_USE_LITE_PROTO=ON for WebAssembly build.
f.write(
r"""
list(APPEND VCPKG_CMAKE_CONFIGURE_OPTIONS
"-DONNX_USE_LITE_PROTO=ON"
)"""
)For native Linux builds, |
This reverts commit 74c219a.
Will integrate with 1.20.1 |
ONNXRUNTIME CI running: microsoft/onnxruntime#26579 Signed-off-by: Ti-Tai Wang <[email protected]>
|
Does it still need #26597 ? Or does the PR description need update |
Thanks. It's also included in this PR. |
This pull request updates the ONNX dependency from version 1.19.1 to 1.20.1 across the build system, patches, and documentation. It ensures that all relevant files, patches, and metadata are consistent with the new ONNX version, and updates the operator documentation to reflect changes in ONNX opset versions.
ONNX Dependency Update:
cmake/deps.txt,cmake/vcpkg-ports/onnx/vcpkg.json, and the submodule reference incmake/external/onnx. Also updated the SHA512 incmake/vcpkg-ports/onnx/portfile.cmaketo match the new ONNX release. [1] [2] [3] [4]Patch and Build System Synchronization:
cmake/patches/onnx/onnx.patchandcmake/vcpkg-ports/onnx/binskim.patch) to match the new ONNX version, including updates for minimal build options and source file exclusions. [1] [2]onnxruntime_add_include_to_targetcall incmake/onnxruntime_unittests.cmaketo include${PROTOBUF_LIB}for correct dependency propagation.Documentation Updates:
docs/OperatorKernels.mdto reflect the new opset version for theCastoperator (now 25+) and added the previous version (24) for clarity.docs/How_To_Update_ONNX_Dev_Notes.mdto mention the importance of patch synchronization and SHA updates.