Add BatchNorm kernel for ROCm #9014
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mindest
added
the
training
weixingzhang
approved these changes
Sep 13, 2021
suffiank
pushed a commit
that referenced
this pull request
Sep 21, 2021
* Add BatchNorm kernel for ROCm, update BN test * correct epsilon_ setting; limit min epsilon
wangyems
added a commit
that referenced
this pull request
Sep 22, 2021
* Revert "Fix nightly CI pipeline to generate ROCm 4.2 wheels and add ROCm 4.3.1 wheels (#9101)" This reverts commit 4788839. * Add BatchNorm kernel for ROCm (#9014) * Add BatchNorm kernel for ROCm, update BN test * correct epsilon_ setting; limit min epsilon * Upgrade ROCm CI pipeline for ROCm 4.3.1 and permit run inside container (#9070) * try to run inside 4.3.1 container * no \ in container run command * remove networking options * try with adding video render groups * add job to build docker image * try without 1st stage * change alpha, beta to float * try adding service connection * retain huggingface directory * static video and render gid * use runtime expression for variables * install torch-ort * pin sacrebleu==1.5.1 * update curves for rocm 4.3.1 * try again * disable determinism and only check tail of loss curve and with a much larger threshold of 0.05 * disable RoBERTa due to high run variablity on ROCm 4.3.1 * put reduction unit tests back in * Fix nightly CI pipeline to generate ROCm 4.2 wheels and add ROCm 4.3.1 wheels (#9101) * make work for both rocm 4.2 and rocm 4.3.1 * fix rocm 4.3.1 docker image reference * fix CUDA_VERSION to ROCM_VERSION * fix ReduceConsts conflict def * add ifdef to miopen_common.h as well * trailing ws Co-authored-by: wangye <[email protected]> Co-authored-by: mindest <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
BatchNormInternalandBatchNormalizationGradfor ROCm EPspatialas per onnx specMotivation and Context
1-P model TwinBERT needs this for training on Mi100 clusters.