Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify name uniquification in inliner #1953

Merged
merged 1 commit into from
Nov 15, 2024
Merged

Conversation

gramalingam
Copy link
Collaborator

The current implementation of using the entire call-stack to produce unique names produces very long names, which makes debugging harder. Simplify this for now. (We may need some investigation to produce more meaningful names, which is future work.)

Copy link

codecov bot commented Nov 15, 2024

❌ 1 Tests Failed:

Tests completed Failed Passed Skipped
14300 1 14299 1619
View the top 1 failed tests by shortest run time
onnxscript.backend.onnx_export_test.TestOnnxBackEnd::test_export2python_produces_correct_onnx_script_model_0060_test_argmin_negative_axis_keepdims_example
Stack Traces | 0.004s run time
onnxscript\backend\onnx_export_test.py:137: in extract_functions
    mod = importlib.import_module(import_name)
C:\hostedtoolcache\windows\Python\3.10.11\x64\lib\importlib\__init__.py:126: in import_module
    return _bootstrap._gcd_import(name[level:], package, level)
E   ModuleNotFoundError: No module named 'tests.onnx_backend_test_code.test_argmin_negative_axis_keepdims_example'

The above exception was the direct cause of the following exception:
.nox\test\lib\site-packages\parameterized\parameterized.py:620: in standalone_func
    return func(*(a + p.args), **p.kwargs, **kw)
onnxscript\backend\onnx_export_test.py:271: in test_export2python_produces_correct_onnx_script_model
    functions = extract_functions(backend_test.name, code, self.test_folder)
onnxscript\backend\onnx_export_test.py:139: in extract_functions
    raise AssertionError(
E   AssertionError: Unable to import 'tests.onnx_backend_test_code.test_argmin_negative_axis_keepdims_example' (e=No module named 'tests.onnx_backend_test_code.test_argmin_negative_axis_keepdims_example') (file: 'D:\\a\\onnxscript\\onnxscript\\tests\\onnx_backend_test_code\\test_argmin_negative_axis_keepdims_example.py', absolute path: 'D:\\a\\onnxscript\\onnxscript\\tests\\onnx_backend_test_code\\test_argmin_negative_axis_keepdims_example.py', current folder: D:\a\onnxscript\onnxscript
E   ---- CONTENT --
E   import numpy
E   from onnx import TensorProto
E   from onnx.helper import make_tensor
E   from onnxscript import script, external_tensor
E   from onnxscript.values import Opset
E   from onnxscript.onnx_types import FLOAT, INT64
E   from onnxscript.onnx_opset import opset13
E   
E   @script()
E   def bck_test_argmin_negative_axis_keepdims_example(data: FLOAT[2,2]) -> (INT64[2,1]):
E       result = opset13.ArgMin(data, axis=-1, keepdims=1)
E       return result

To view more test analytics, go to the Test Analytics Dashboard
Got feedback? Let us know on Github

@gramalingam gramalingam merged commit 88dca66 into main Nov 15, 2024
25 of 41 checks passed
@gramalingam gramalingam deleted the rama/inlined-name branch November 15, 2024 23:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

2 participants