Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A couple of ir utilities #1972

Merged
merged 6 commits into from
Dec 9, 2024
Merged

A couple of ir utilities #1972

merged 6 commits into from
Dec 9, 2024

Conversation

gramalingam
Copy link
Collaborator

Extracting out some IR utilities from the ongoing fusion draft version, which are useful for debugging and use in other (constant-folding and rewriter) optimizations.

onnxscript/rewriter/_ir_utils.py Fixed Show fixed Hide fixed
onnxscript/rewriter/_ir_utils.py Fixed Show fixed Hide fixed
Copy link

codecov bot commented Dec 3, 2024

❌ 41 Tests Failed:

Tests completed Failed Passed Skipped
16167 41 16126 3311
View the top 3 failed tests by shortest run time
onnxscript.tools.benchmark.export_model_test.BenchmarkTest::test_export_model_phi_cpu_dynamo
Stack Traces | 0.001s run time
..../test/lib/python3.9.../site-packages/pytest_subtests/plugin.py:112: in _addSkip
    for x, y in self.instance._outcome.errors
E   AttributeError: 'NoneType' object has no attribute 'errors'
onnxscript.tools.transformers_models.mistral_test.TestExportMistral::test_mistral_export_cpu_export_api
Stack Traces | 0.001s run time
..../test/lib/python3.9.../site-packages/pytest_subtests/plugin.py:112: in _addSkip
    for x, y in self.instance._outcome.errors
E   AttributeError: 'NoneType' object has no attribute 'errors'
onnxscript.tools.transformers_models.phi3_test.TestExportPhi3::test_phi3_dort_static
Stack Traces | 0.001s run time
..../test/lib/python3.9.../site-packages/pytest_subtests/plugin.py:112: in _addSkip
    for x, y in self.instance._outcome.errors
E   AttributeError: 'NoneType' object has no attribute 'errors'

To view more test analytics, go to the Test Analytics Dashboard
📢 Thoughts on this report? Let us know!

@gramalingam gramalingam enabled auto-merge (squash) December 4, 2024 21:15
Copy link
Contributor

@shubhambhokare1 shubhambhokare1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we add a couple of tests demonstrating this functionality of display_slice?

onnxscript/rewriter/_ir_utils.py Outdated Show resolved Hide resolved
onnxscript/rewriter/_ir_utils.py Show resolved Hide resolved
onnxscript/rewriter/_ir_utils.py Show resolved Hide resolved
onnxscript/rewriter/_ir_utils.py Fixed Show fixed Hide fixed
onnxscript/rewriter/_ir_utils.py Fixed Show fixed Hide fixed
Copy link
Contributor

@shubhambhokare1 shubhambhokare1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! nit: Fix lintrunner warnings

@gramalingam gramalingam merged commit 86644e9 into main Dec 9, 2024
20 of 41 checks passed
@gramalingam gramalingam deleted the rama/irutils branch December 9, 2024 19:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

2 participants