[torchlib] Implement window functions #1995

justinchuby · 2025-01-03T17:58:01Z

BlackmanWindow
Hann
Hamming

- BlackmanWindow - Hann - Hamming

Copilot reviewed 1 out of 1 changed files in this pull request and generated no comments.

codecov · 2025-01-03T18:00:48Z

❌ 39 Tests Failed:

Tests completed	Failed	Passed	Skipped
11383	39	11344	2012

View the full list of 3 ❄️ flaky tests

tests.eager_mode_test.TestEagerModeArguments_0_reference_runtime::test_function_input_and_attribute_by_kwargs_out_of_order

Flake rate in main: 39.26% (Passed 12653 times, Failed 8180 times)

Stack Traces | 0.002s run time

..../test_torch_nightly/lib/python3.11.../reference/ops/_op.py:91: in run
    res = self._run(x, y)
..../test_torch_nightly/lib/python3.11.../reference/ops/_op.py:139: in _run
    res = (convert_from_ml_dtypes(res[0]),)
..../test_torch_nightly/lib/python3.11.../onnx/reference/custom_element_types.py:50: in convert_from_ml_dtypes
    return array.view(dtype=dtype)
E   ValueError: Changing the dtype of a 0d array is only supported if the itemsize is unchanged

The above exception was the direct cause of the following exception:
tests/eager_mode_test.py:115: in test_function_input_and_attribute_by_kwargs_out_of_order
    self.assertEqual(add_with_alpha(alpha=3.0, other=2.0, this=1.0), 7.0)
onnxscript/values.py:576: in __call__
    return evaluator.default().eval_function(self, args, kwargs)
onnxscript/evaluator.py:307: in eval_function
    result = function.function(*adapted_args, **adapted_kwargs)
tests/eager_mode_test.py:59: in add_with_alpha
    other = op.Mul(other, alpha)
.../onnx_opset/_impl/opset14.py:696: in Mul
    return op(*self._prepare_inputs(schema, A, B))
onnxscript/values.py:304: in __call__
    return evaluator.default().eval(schema, args, kwargs)
onnxscript/evaluator.py:194: in eval
    outputs = self._eval(schema, inputs, attributes, closure)
onnxscript/evaluator.py:526: in _eval
    result = session.run(None, session_run_input)
..../test_torch_nightly/lib/python3.11.../onnx/reference/reference_evaluator.py:593: in run
    outputs = node.run(*inputs, **linked_attributes)
..../test_torch_nightly/lib/python3.11.../reference/ops/_op.py:114: in run
    res = OpRunBinary.run(self, x, y)
..../test_torch_nightly/lib/python3.11.../reference/ops/_op.py:93: in run
    raise TypeError(
E   TypeError: Issues with types <class 'numpy.ndarray'>, <class 'numpy.ndarray'> (binary operator 'Mul').

tests.eager_mode_test.TestEagerModeArguments_0_reference_runtime::test_function_some_input_by_kwargs

Flake rate in main: 39.26% (Passed 12653 times, Failed 8180 times)

Stack Traces | 0.002s run time

..../test_torch_nightly/lib/python3.11.../reference/ops/_op.py:91: in run
    res = self._run(x, y)
..../test_torch_nightly/lib/python3.11.../reference/ops/_op.py:139: in _run
    res = (convert_from_ml_dtypes(res[0]),)
..../test_torch_nightly/lib/python3.11.../onnx/reference/custom_element_types.py:50: in convert_from_ml_dtypes
    return array.view(dtype=dtype)
E   ValueError: Changing the dtype of a 0d array is only supported if the itemsize is unchanged

The above exception was the direct cause of the following exception:
tests/eager_mode_test.py:106: in test_function_some_input_by_kwargs
    self.assertEqual(add_with_alpha(1.0, other=2.0), 3.0)
onnxscript/values.py:576: in __call__
    return evaluator.default().eval_function(self, args, kwargs)
onnxscript/evaluator.py:307: in eval_function
    result = function.function(*adapted_args, **adapted_kwargs)
tests/eager_mode_test.py:59: in add_with_alpha
    other = op.Mul(other, alpha)
.../onnx_opset/_impl/opset14.py:696: in Mul
    return op(*self._prepare_inputs(schema, A, B))
onnxscript/values.py:304: in __call__
    return evaluator.default().eval(schema, args, kwargs)
onnxscript/evaluator.py:194: in eval
    outputs = self._eval(schema, inputs, attributes, closure)
onnxscript/evaluator.py:526: in _eval
    result = session.run(None, session_run_input)
..../test_torch_nightly/lib/python3.11.../onnx/reference/reference_evaluator.py:593: in run
    outputs = node.run(*inputs, **linked_attributes)
..../test_torch_nightly/lib/python3.11.../reference/ops/_op.py:114: in run
    res = OpRunBinary.run(self, x, y)
..../test_torch_nightly/lib/python3.11.../reference/ops/_op.py:93: in run
    raise TypeError(
E   TypeError: Issues with types <class 'numpy.ndarray'>, <class 'numpy.ndarray'> (binary operator 'Mul').

tests.eager_mode_test.TestEagerModeArguments_0_reference_runtime::test_function_all_input_by_kwargs

Flake rate in main: 39.26% (Passed 12653 times, Failed 8180 times)

Stack Traces | 0.002s run time

..../test_torch_nightly/lib/python3.11.../reference/ops/_op.py:91: in run
    res = self._run(x, y)
..../test_torch_nightly/lib/python3.11.../reference/ops/_op.py:139: in _run
    res = (convert_from_ml_dtypes(res[0]),)
..../test_torch_nightly/lib/python3.11.../onnx/reference/custom_element_types.py:50: in convert_from_ml_dtypes
    return array.view(dtype=dtype)
E   ValueError: Changing the dtype of a 0d array is only supported if the itemsize is unchanged

The above exception was the direct cause of the following exception:
tests/eager_mode_test.py:109: in test_function_all_input_by_kwargs
    self.assertEqual(add_with_alpha(this=1.0, other=2.0), 3.0)
onnxscript/values.py:576: in __call__
    return evaluator.default().eval_function(self, args, kwargs)
onnxscript/evaluator.py:307: in eval_function
    result = function.function(*adapted_args, **adapted_kwargs)
tests/eager_mode_test.py:59: in add_with_alpha
    other = op.Mul(other, alpha)
.../onnx_opset/_impl/opset14.py:696: in Mul
    return op(*self._prepare_inputs(schema, A, B))
onnxscript/values.py:304: in __call__
    return evaluator.default().eval(schema, args, kwargs)
onnxscript/evaluator.py:194: in eval
    outputs = self._eval(schema, inputs, attributes, closure)
onnxscript/evaluator.py:526: in _eval
    result = session.run(None, session_run_input)
..../test_torch_nightly/lib/python3.11.../onnx/reference/reference_evaluator.py:593: in run
    outputs = node.run(*inputs, **linked_attributes)
..../test_torch_nightly/lib/python3.11.../reference/ops/_op.py:114: in run
    res = OpRunBinary.run(self, x, y)
..../test_torch_nightly/lib/python3.11.../reference/ops/_op.py:93: in run
    raise TypeError(
E   TypeError: Issues with types <class 'numpy.ndarray'>, <class 'numpy.ndarray'> (binary operator 'Mul').

To view more test analytics, go to the Test Analytics Dashboard
📢 Thoughts on this report? Let us know!

titaiwangms

Prob not easy, but maybe we need a test?

onnxscript/function_libs/torch_lib/ops/core.py

justinchuby · 2025-01-06T20:53:31Z

Prob not easy, but maybe we need a test?

Done. Thanks!

Implement window functions

48f7449

- BlackmanWindow - Hann - Hamming

justinchuby added the topic: torch_lib Related to the torch/aten function lib in development label Jan 3, 2025

justinchuby requested a review from Copilot January 3, 2025 17:58

justinchuby assigned gramalingam and shubhambhokare1 Jan 3, 2025

Copilot AI reviewed Jan 3, 2025

View reviewed changes

justinchuby unassigned gramalingam and shubhambhokare1 Jan 3, 2025

justinchuby requested review from gramalingam and shubhambhokare1 January 3, 2025 17:58

justinchuby force-pushed the justinchu/windows branch from ad8fd54 to 48f7449 Compare January 3, 2025 18:34

justinchuby requested a review from titaiwangms January 6, 2025 17:09

Merge branch 'main' into justinchu/windows

63b302c

titaiwangms approved these changes Jan 6, 2025

View reviewed changes

onnxscript/function_libs/torch_lib/ops/core.py Outdated Show resolved Hide resolved

justinchuby added 2 commits January 6, 2025 10:34

Add torch_op decorators and dtype checks

67003fe

Update default dtype handling in window functions

5606375

tests

9530da9

justinchuby enabled auto-merge (squash) January 6, 2025 20:54

justinchuby merged commit 98861b0 into main Jan 6, 2025
16 of 27 checks passed

justinchuby deleted the justinchu/windows branch January 6, 2025 21:11

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[torchlib] Implement window functions #1995

[torchlib] Implement window functions #1995

justinchuby commented Jan 3, 2025 •

edited

Loading

codecov bot commented Jan 3, 2025 •

edited

Loading

titaiwangms left a comment

justinchuby commented Jan 6, 2025

[torchlib] Implement window functions #1995

[torchlib] Implement window functions #1995

Conversation

justinchuby commented Jan 3, 2025 • edited Loading

Choose a reason for hiding this comment

codecov bot commented Jan 3, 2025 • edited Loading

❌ 39 Tests Failed:

titaiwangms left a comment

Choose a reason for hiding this comment

justinchuby commented Jan 6, 2025

justinchuby commented Jan 3, 2025 •

edited

Loading

codecov bot commented Jan 3, 2025 •

edited

Loading