-
Notifications
You must be signed in to change notification settings - Fork 88
Create initializers not constant nodes in constant folding pass #2650
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create initializers not constant nodes in constant folding pass #2650
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2650 +/- ##
==========================================
- Coverage 70.41% 70.24% -0.17%
==========================================
Files 224 224
Lines 26600 26605 +5
Branches 2645 2645
==========================================
- Hits 18730 18689 -41
- Misses 6945 6991 +46
Partials 925 925 ☔ View full report in Codecov by Sentry. |
|
Need onnx/ir-py#227 |
|
This might be considered bc breaking in terms of graph changes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
|
Just making sure: is the replaced initializer immediately freed (if there is no users)? We need to do that to avoid memory usage jumps. |
I will check. |
Partially From #2598
This provides a better optimized graph after constant folding in terms of the number of nodes, which is better for debugging.