Skip to content

Conversation

stefanseeger
Copy link
Contributor

For me reading the doc was a bit confusing.

  1. The / character implies a "or" to me not an and (but I'm no native speaker)
  2. Not highlighting the property names made it harder to read
  3. There was a missing "." in the path description

@stefanseeger stefanseeger changed the title docs: Enhance api/class-browsercontext.md docs: Enhance docs/src/api/class-browsercontext.md Oct 2, 2025
Copy link
Contributor

@dgozman dgozman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the PR! Unfortunately, it's not enough to just change this file. You need to run npm run build or npm run watch. See contributing guide for more details. Thank you!

stefanseeger and others added 2 commits October 6, 2025 10:17
@stefanseeger
Copy link
Contributor Author

@microsoft-github-policy-service agree

Copy link
Contributor

github-actions bot commented Oct 6, 2025

Test results for "tests 1"

1 failed
❌ [playwright-test] › ui-mode-test-network-tab.spec.ts:204 › should not preserve selection across test runs @windows-latest-node18-1

2 flaky ⚠️ [firefox-library] › library/inspector/cli-codegen-1.spec.ts:1079 › cli codegen › should not throw csp directive violation errors `@firefox-ubuntu-22.04-node18`
⚠️ [firefox-page] › page/page-wait-for-function.spec.ts:104 › should work with strict CSP policy `@firefox-ubuntu-22.04-node18`

46916 passed, 811 skipped


Merge workflow run.

Copy link
Contributor

@dgozman dgozman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the PR! Looking great, merging in.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants