Repository navigation
test(webkit): cover service worker headers with routing enabled - #43754
Conversation
Test results for "MCP"1 failed 5193 passed, 616 skipped Merge workflow run. |
Test results for "tests 1"1 flaky23592 passed, 707 skipped Merge workflow run. |
🟢 The CI failure is a confirmed pre-existing flakeHi, I'm the Playwright bot. I checked the CI reports, the PR changes, and the refreshed test-results database. DetailsThe reported failure is not caused by this PR. The MCP report lists one failure; the tests 1 report has no failures. Pre-existing flake
The same test on the same bot failed with the identical assertion before this PR: on main, October 14, SHA This PR only extends a page interception test and its service-worker asset to check request headers. The failing MCP test navigates to the hello-world page, does not load that asset, and exercises unchanged persistent-browser storage behavior. Triaged by the Playwright bot - agent run |
Extend the existing service-worker interception test to check that routing preserves explicit
cache-control,accept-languageandacceptrequest headers. WebKit previously overwrote Cache-Control when routing disabled caching; the production fix already landed in WebKit/WebKit#69997. Keep the existing coverage on frozen WebKit, which predates that fix.The same test fails with WebKit 26.5 r2336 from Playwright 1.62.1 (
no-cacheinstead ofmax-age=12345) and passes with current Chromium, Firefox and WebKit. On Linux, the three related spec files pass: 264 passed, 9 skipped.npm run buildandnpm run flintpass.Fixes: #41932
Prepared by the triage workflow.