Skip to content

test(webkit): cover tap after canceled pointerdown - #43757

Merged
Dmitry Gozman (dgozman) merged 1 commit into
mainfrom
triage/43569/40864438928-1
Oct 29, 2026
Merged

Dmitry Gozman (dgozman) merged 1 commit into
mainfrom
triage/43569/40864438928-1

Conversation

@microsoft-playwright-automation

Copy link
Copy Markdown
Contributor

WebKit r2386 (#43743) now preserves click when pointerdown is canceled, while suppressing compatibility mouse events.

Extend the existing TA-001 tap event test to cover this case. The added assertion fails on r2384 and passes on r2386.

Fixes: #43569

Prepared by the triage workflow.

@github-actions

Copy link
Copy Markdown
Contributor

Test results for "MCP"

5194 passed, 616 skipped


Merge workflow run.

@github-actions

Copy link
Copy Markdown
Contributor

Test results for "tests 1"

23593 passed, 707 skipped


Merge workflow run.

@dgozman
Dmitry Gozman (dgozman) marked this pull request as ready for review October 29, 2026 14:52
@github-actions

Copy link
Copy Markdown
Contributor

Test results for "tests 2"

1 failed
❌ [webkit-library] › library/tracing.spec.ts:565 › TR-023 should produce screencast frames crop @webkit-playwright-x64-server2025-64-core

15 flaky ⚠️ [chromium-library] › library/video.spec.ts:762 › screencast › VI-030 should work with video+trace `@chromium-playwright-x64-server2025-64-core`
⚠️ [chromium-page] › page/page-screenshot.spec.ts:534 › page screenshot › SS-039 should take fullPage screenshots during navigation `@tracing-chromium`
⚠️ [chromium-library] › library/inspector/cli-codegen-csharp.spec.ts:231 › CG-160 should work with --save-har and --save-har-glob in xunit `@chrome-ubuntu-22.04`
⚠️ [chromium-library] › library/tracing.spec.ts:565 › TR-023 should produce screencast frames crop `@chromium-macos-15-large`
⚠️ [chromium-library] › library/webmcp.spec.ts:256 › WM-014 should list and call tools in cross-origin and nested frames `@chromium-ubuntu-22.04-node26`
⚠️ [chromium-library] › library/popup.spec.ts:279 › PO-028 should not throw when click closes popup `@chrome-beta-ubuntu-22.04`
⚠️ [chromium-library] › library/capabilities.spec.ts:105 › CA-008 should support webgl Radoslav Kirilov (@smoke) `@chrome-macos-latest`
⚠️ [chromium-library] › library/screencast.spec.ts:28 › SC-001 screencast.start delivers frames via onFrame callback `@chrome-macos-latest`
⚠️ [chromium-library] › library/screenshot.spec.ts:181 › page screenshot › SS-079 should handle vh units `@chrome-macos-latest`
⚠️ [chromium-page] › page/page-screenshot.spec.ts:404 › page screenshot › SS-095 should capture webgl canvas after its drawing buffer is resized `@chrome-macos-latest`
⚠️ [firefox-library] › library/inspector/cli-codegen-aria.spec.ts:87 › CG-100 should update aria snapshot highlight `@firefox-macos-15-large`
⚠️ [webkit-library] › library/heap.spec.ts:304 › LE-014 cycle handles `@webkit-playwright-x64-server2025-64-core`
⚠️ [webkit-library] › library/trace-viewer.spec.ts:1937 › TV-087 should not leak recorders `@webkit-macos-15-xlarge`
⚠️ [webkit-library] › library/trace-viewer.spec.ts:2019 › TV-090 canvas clipping `@webkit-macos-15-xlarge`
⚠️ [webkit-library] › library/trace-viewer.spec.ts:1937 › TV-087 should not leak recorders `@webkit-macos-15-large`

127076 passed, 4126 skipped


Merge workflow run.

@github-actions

Copy link
Copy Markdown
Contributor

🟢 The CI failure is a confirmed pre-existing flake

Hi, I'm the Playwright bot. I checked the latest CI report, the PR diff, and this test's history.

Details

The latest merged report has one failed test; the other 15 reported flakes passed on retry. I found no failure caused by this PR. Commit 5e122155 only extends TA-001 in tests/library/tap.spec.ts; it changes no tracing code, shared fixtures, or browser versions.

Pre-existing flake / infra

[webkit-library] › library/tracing.spec.ts:565 › TR-023 should produce screencast frames crop on webkit-playwright-x64-server2025-64-core exceeds the 30-second timeout on all four attempts. The failing job shows rafraf() waiting for animation frames during the painting loop, not a failed tap-event assertion.

After refreshing the aggregated CI database, I found the same test on the same Windows bot failing independently on main:

  • Run 40741511737, commit 138933c03f48: timed out on all four attempts.
  • Run 40774118089, commit 4d05531e1483: timed out in page.evaluate, then passed on the first retry.

Both runs were on October 28, before this PR opened on October 29. This confirms an existing intermittent timeout rather than a regression from this PR.

Triaged by the Playwright bot - agent run

@dgozman
Dmitry Gozman (dgozman) merged commit e618303 into main Oct 29, 2026
56 of 57 checks passed
@dgozman
Dmitry Gozman (dgozman) deleted the triage/43569/40864438928-1 branch October 29, 2026 19:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: WebKit: tap() dispatches no click when pointerdown's default is prevented

2 participants