Allow to fetch images from an URL in <img> src #95
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@microsoft-github-policy-service agree |
|
Looks excellent. Would you add tests and update tsdoc for this feature? |
|
Updated docs and added a test for URL image fetching. |
|
please pull from main and fix the tests. |
ultmaster
reviewed
Aug 18, 2025
| function generatePythonFile(jsonData: ComponentSpec[]): string { | ||
| let pythonCode = `# This file is auto-generated from component documentation. | ||
| # Do not edit manually. Run \`npm run build-comment\` to regenerate. | ||
| # Do not edit manually. Run \`npm run docs:build\` to regenerate. |
There was a problem hiding this comment.
please revert unnecessary changes.
|
The tests need to be fixed before merging. |
|
fixed tests for image fetching in Webpage |
|
I've just created an image url for the testing, please use this one: Also merge from main again. Apologize for the prettier just merged. |
|
updated the image URL for testing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implementation that allows to set
srcin a<img>tag to the URL of an image.