Benjaming/fix pmc columns#39
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes an issue with PMC (Performance Monitor Counter) columns not being displayed correctly. The fix addresses two main problems: (1) PMC columns were not showing when PMU counters were used as sampling sources rather than separate counting events, and (2) an async reentrancy issue in the column update mechanism that could cause infinite update loops.
Changes:
- Version bump from 1.2.0 to 1.2.1 for bugfix release
- Fixed PMC column display by generating synthetic counter events when PMU counters are used as sampling sources
- Replaced synchronous Utils.RunSync call with fire-and-forget async pattern to prevent UI blocking while still handling reentrancy
Reviewed changes
Copilot reviewed 5 out of 6 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| src/ProfileExplorerUI/ProfileExplorerUI.csproj | Version bump to 1.2.1 for bugfix release |
| installer/x64/prepare-installer.cmd | Updated installer version to 1.2.1 |
| installer/arm64/prepare-installer.cmd | Updated installer version to 1.2.1 |
| .gitignore | Added exception to preserve installer directories despite arm64/x64 ignore patterns |
| src/ProfileExplorerUI/Document/IRDocumentHost.xaml.cs | Replaced Utils.RunSync with fire-and-forget async pattern for better reentrancy handling |
| src/ProfileExplorerCore/Profile/ETW/ETWProfileDataProvider.cs | Added synthetic PMC event generation for PMU sampling sources and removed unnecessary Initialized check |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
jhpohovey
approved these changes
Feb 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.