force interpretation in XAML converter parameter parsing to use . d…#40
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes locale-dependent parsing of numeric ConverterParameter values in WPF converters by forcing invariant-culture parsing, preventing crashes and incorrect scaling/opacity when the user’s locale doesn’t use . as the decimal separator (Issue #38).
Changes:
- Parse
DoubleScalingConverter’sConverterParameterusingCultureInfo.InvariantCulturein bothConvertandConvertBack. - Parse
ColorBrushOpacityConverter’s opacityConverterParameterusingCultureInfo.InvariantCulture.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
ivberg
approved these changes
Mar 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For language / region locale where
.is not used for decimal like in100.0versus100,0, causing a formatting error.Also, should fix a silent error for regions where
.is used for thousands place (meaning100.0may be interpreted as 1000).Should fix #38