Skip to content

Commit

Permalink
[BUG][Promptflow SDK& CLI] docker build build is confusing (#379)
Browse files Browse the repository at this point in the history
# Description

Please add an informative description that covers that changes made by
the pull request and link all relevant issues.

# All Promptflow Contribution checklist:
- [ ] **The pull request does not introduce [breaking changes]**
- [ ] **CHANGELOG is updated for new features, bug fixes or other
significant changes.**
- [ ] **I have read the [contribution guidelines](../CONTRIBUTING.md).**

## General Guidelines and Best Practices
- [ ] Title of the pull request is clear and informative.
- [ ] There are a small number of commits, each of which have an
informative message. This means that previously merged commits do not
appear in the history of the PR. For more information on cleaning up the
commits in your PR, [see this
page](https://github.com/Azure/azure-powershell/blob/master/documentation/development-docs/cleaning-up-commits.md).

### Testing Guidelines
- [ ] Pull request includes test coverage for the included changes.

---------

Co-authored-by: Ying Chen <[email protected]>
  • Loading branch information
YingChen1996 and Ying Chen authored Sep 14, 2023
1 parent 0100090 commit 3f8b7f4
Show file tree
Hide file tree
Showing 6 changed files with 12 additions and 12 deletions.
4 changes: 2 additions & 2 deletions docs/cloud/azureai/deploy-to-azure-appservice.md
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ This example demos how to deploy [web-classification](https://github.com/microso
Use the command below to build a flow as docker format app:

```bash
pf flow build --source ../../flows/standard/web-classification --output build --format docker
pf flow build --source ../../flows/standard/web-classification --output dist --format docker
```

Note that all dependent connections must be created before building as docker.
Expand All @@ -27,7 +27,7 @@ The two scripts will do the following things:
:::{tab-item} Bash
Example command to use bash script:
```shell
bash deploy.sh --path build -i <image_tag> --name my_app_23d8m -r <docker registery> -g <resource_group>
bash deploy.sh --path dist -i <image_tag> --name my_app_23d8m -r <docker registery> -g <resource_group>
```
See the full parameters by `bash deploy.sh -h`.
:::
Expand Down
4 changes: 2 additions & 2 deletions docs/how-to-guides/deploy-a-flow/deploy-using-docker.md
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,7 @@ refer to [Setup connection for web-classifiction](https://github.com/microsoft/p
Use the command below to build a flow as docker format app:

```bash
pf flow build --source ../../flows/standard/web-classification --output build --format docker
pf flow build --source ../../flows/standard/web-classification --output dist --format docker
```

Note that all dependent connections must be created before exporting as docker.
Expand All @@ -65,7 +65,7 @@ Like other Dockerfile, you need to build the image first. You can tag the image
Run the command below to build image:

```bash
docker build build -t web-classification-serve
docker build dist -t web-classification-serve
```

### Run Docker image
Expand Down
4 changes: 2 additions & 2 deletions examples/tutorials/e2e-development/chat-with-pdf.md
Original file line number Diff line number Diff line change
Expand Up @@ -310,7 +310,7 @@ the other choices, please refer to [flow deploy docs](https://microsoft.github.i
Use the command below to build a flow as docker format app:

```bash
pf flow build --source . --output build --format docker
pf flow build --source . --output dist --format docker
```

### Deploy with Docker
Expand All @@ -321,7 +321,7 @@ Like other Dockerfile, you need to build the image first. You can tag the image
Run the command below to build image:

```shell
docker build build -t chat-with-pdf-serve
docker build dist -t chat-with-pdf-serve
```

#### Run Docker image
Expand Down
4 changes: 2 additions & 2 deletions examples/tutorials/flow-deploy/azure-app-service/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ pf connection create --file ../../../connections/azure_openai.yml --set api_key=
Use the command below to build a flow as docker format app:

```bash
pf flow build --source ../../../flows/standard/web-classification --output build --format docker
pf flow build --source ../../../flows/standard/web-classification --output dist --format docker
```


Expand All @@ -32,7 +32,7 @@ The two scripts will do the following things:

Example command to use bash script:
```shell
bash deploy.sh --path build -i <image_tag> --name my_app_23d8m -r <docker registery> -g <resource_group>
bash deploy.sh --path dist -i <image_tag> --name my_app_23d8m -r <docker registery> -g <resource_group>
```

Example command to use powershell script:
Expand Down
4 changes: 2 additions & 2 deletions examples/tutorials/flow-deploy/docker/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ pf connection create --file ../../../connections/azure_openai.yml --set api_key=
Use the command below to build a flow as docker format app:

```bash
pf flow build --source ../../../flows/standard/web-classification --output build --format docker
pf flow build --source ../../../flows/standard/web-classification --output dist --format docker
```

## Deploy with Docker
Expand All @@ -25,7 +25,7 @@ Like other Dockerfile, you need to build the image first. You can tag the image
Run the command below to build image:

```shell
docker build build -t web-classification-serve
docker build dist -t web-classification-serve
```

### Run Docker image
Expand Down
4 changes: 2 additions & 2 deletions examples/tutorials/flow-deploy/kubernetes/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ pf connection create --file ../../../connections/azure_openai.yml --set api_key=
Use the command below to build a flow as docker format app:

```bash
pf flow build --source ../../../flows/standard/web-classification --output build --format docker
pf flow build --source ../../../flows/standard/web-classification --output dist --format docker
```

## Deploy with Kubernetes
Expand All @@ -26,7 +26,7 @@ Like other Dockerfile, you need to build the image first. You can tag the image
Then run the command below:

```shell
cd build
cd dist
docker build . -t web-classification-serve
```

Expand Down

0 comments on commit 3f8b7f4

Please sign in to comment.