Skip to content

Commit

Permalink
update tests
Browse files Browse the repository at this point in the history
  • Loading branch information
wangchao1230 committed Apr 1, 2024
1 parent 84cc10f commit 4c748d4
Show file tree
Hide file tree
Showing 3 changed files with 7 additions and 3 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@

from promptflow import PFClient
from promptflow._sdk.entities import CustomConnection
from promptflow._sdk._version import VERSION
from promptflow.recording.record_mode import is_replay

from ..utils import PFSOperations, check_activity_end_telemetry
Expand All @@ -34,7 +35,7 @@ def test_list_connections(self, pf_client: PFClient, pfs_op: PFSOperations) -> N

def test_list_connections_with_different_user_agent(self, pf_client: PFClient, pfs_op: PFSOperations) -> None:
create_custom_connection(pf_client)
base_user_agent = ["local_pfs/0.0.1"]
base_user_agent = [f"local_pfs/{VERSION}"]
for _, extra_user_agent in enumerate(
[
["another_test_user_agent/0.0.1"],
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,8 @@

import pytest

from promptflow._sdk._version import VERSION

from ..utils import PFSOperations, check_activity_end_telemetry


Expand Down Expand Up @@ -34,7 +36,7 @@ def test_post_telemetry(self, pfs_op: PFSOperations) -> None:
with check_activity_end_telemetry(
activity_name="pf.flow.test",
activity_type="InternalCall",
user_agent=f"{user_agent} local_pfs/0.0.1",
user_agent=f"{user_agent} local_pfs/{VERSION}",
request_id=request_id,
):
response = pfs_op.create_telemetry(
Expand Down
3 changes: 2 additions & 1 deletion src/promptflow/tests/sdk_pfs_test/utils.py
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@
from flask.testing import FlaskClient

from promptflow._sdk._service.utils.utils import encrypt_flow_path
from promptflow._sdk._version import VERSION


@contextlib.contextmanager
Expand All @@ -33,7 +34,7 @@ def check_activity_end_telemetry(
"first_call": True,
"activity_type": "PublicApi",
"completion_status": "Success",
"user_agent": [f"Werkzeug/{werkzeug.__version__}", "local_pfs/0.0.1"],
"user_agent": [f"Werkzeug/{werkzeug.__version__}", f"local_pfs/{VERSION}"],
}
for i, expected_activity in enumerate(expected_activities):
temp = default_expected_call.copy()
Expand Down

0 comments on commit 4c748d4

Please sign in to comment.