Skip to content

Commit

Permalink
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Fix errors
Browse files Browse the repository at this point in the history
0mza987 committed Sep 18, 2023
1 parent 44cdfed commit 661ce1e
Showing 4 changed files with 14 additions and 9 deletions.
13 changes: 8 additions & 5 deletions cspell.json → .cspell.json
Original file line number Diff line number Diff line change
@@ -24,8 +24,7 @@
"scripts/docs/_build/**",
"src/promptflow/promptflow/azure/_restclient/flow/**",
"src/promptflow/tests/**",
"**/flow.dag.yaml",
"docs/cloud/azureai/faq.md"
"**/flow.dag.yaml"
],
"words": [
"propmtflow",
@@ -52,7 +51,6 @@
"logit",
"hnsw",
"chatml",
"dtype",
"UNLCK",
"KHTML",
"numlines",
@@ -68,7 +66,10 @@
"pfutil",
"mgmt",
"wsid",
"westus"
"westus",
"msrest",
"cref",
"msal"
],
"ignoreWords": [
"openmpi",
@@ -118,11 +119,13 @@
"continuumio",
"pydantic",
"iterrows",
"dtype",
"fillna",
"nlines",
"aggr",
"tcsetattr",
"pysqlite"
"pysqlite",
"AADSTS700082"
],
"allowCompoundWords": true
}
4 changes: 3 additions & 1 deletion .github/workflows/spell_check.yml
Original file line number Diff line number Diff line change
@@ -25,4 +25,6 @@ jobs:
run: npm install -g cspell

- name: Run cspell
run: cspell lint "**"
run: |-
cspell lint "**"
echo -e "\e[91mNote: If the detected words are expected, add them in ".cspell.json".\e[0m"
2 changes: 1 addition & 1 deletion docs/dev/documentation_guidelines.md
Original file line number Diff line number Diff line change
@@ -140,7 +140,7 @@ You can build the documentation site locally to preview the final effect of your
4. Check warnings/errors in the build log, fix them if any, then build again.
5. Open `scripts/docs/_build/index.html` to preview the local doc site.
## Aditional comments
## Additional comments
- **Utilities**: The [autoDocstring](https://marketplace.visualstudio.com/items?itemName=njpwerner.autodocstring) VSCode extension or GitHub Copilot can help autocomplete in this style for you.
4 changes: 2 additions & 2 deletions src/promptflow-tools/tests/test_aoai.py
Original file line number Diff line number Diff line change
@@ -34,7 +34,7 @@ def test_aoai_chat(self, aoai_provider, example_prompt_template, chat_history):
user_input="Fill in more details about trend 2.",
chat_history=chat_history,
)
assert "details about trend 2" in result.lower()
assert "additional details you can include" in result.lower()

def test_aoai_chat_api(self, azure_open_ai_connection, example_prompt_template, chat_history):
result = chat(
@@ -93,7 +93,7 @@ def test_aoai_stream_chat(self, aoai_provider, example_prompt_template, chat_his
answer += next(result)
except Exception:
break
assert "details about trend 2" in answer.lower()
assert "additional details you can include" in answer.lower()

@pytest.mark.parametrize(
"params, expected",

0 comments on commit 661ce1e

Please sign in to comment.