Skip to content

Commit

Permalink
[promptflow][Test] Skip known enum issue in test when Python 3.11 (#1040
Browse files Browse the repository at this point in the history
)

# Description

Skip test `test_ensure_node_inputs_type` in Python 3.11 due to known
enum issue.

# All Promptflow Contribution checklist:
- [x] **The pull request does not introduce [breaking changes].**
- [ ] **CHANGELOG is updated for new features, bug fixes or other
significant changes.**
- [x] **I have read the [contribution guidelines](../CONTRIBUTING.md).**
- [ ] **Create an issue and link to the pull request to get dedicated
review from promptflow team. Learn more: [suggested
workflow](../CONTRIBUTING.md#suggested-workflow).**

## General Guidelines and Best Practices
- [x] Title of the pull request is clear and informative.
- [x] There are a small number of commits, each of which have an
informative message. This means that previously merged commits do not
appear in the history of the PR. For more information on cleaning up the
commits in your PR, [see this
page](https://github.com/Azure/azure-powershell/blob/master/documentation/development-docs/cleaning-up-commits.md).

### Testing Guidelines
- [x] Pull request includes test coverage for the included changes.

---------

Co-authored-by: Hhhilulu <[email protected]>
  • Loading branch information
zhengfeiwang and Hhhilulu committed Nov 8, 2023
1 parent 05d70e3 commit 8924b43
Showing 1 changed file with 4 additions and 0 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -153,6 +153,10 @@ def test_resolve_tool_by_node_with_duplicated_inputs(self, resolver, mocker):
assert isinstance(exec_info.value.inner_exception, NodeInputValidationError)
assert "These inputs are duplicated" in exec_info.value.message

@pytest.mark.skipif(
condition=(sys.version_info.major == 3 and sys.version_info.minor == 11),
reason="BUG 2709800: known issue on enum in Python 3.11",
)
def test_ensure_node_inputs_type(self):
# Case 1: conn_name not in connections, should raise conn_name not found error
tool = Tool(name="mock", type="python", inputs={"conn": InputDefinition(type=["CustomConnection"])})
Expand Down

0 comments on commit 8924b43

Please sign in to comment.