Skip to content

Commit

Permalink
[promptflow][internal] Remove TODO for SQLAlchemy silent warning (#1853)
Browse files Browse the repository at this point in the history
# Description

Remove SQLAlchemy silent warning for 2.x as we already remove the upper
limit.

# All Promptflow Contribution checklist:
- [x] **The pull request does not introduce [breaking changes].**
- [ ] **CHANGELOG is updated for new features, bug fixes or other
significant changes.**
- [x] **I have read the [contribution guidelines](../CONTRIBUTING.md).**
- [ ] **Create an issue and link to the pull request to get dedicated
review from promptflow team. Learn more: [suggested
workflow](../CONTRIBUTING.md#suggested-workflow).**

## General Guidelines and Best Practices
- [x] Title of the pull request is clear and informative.
- [x] There are a small number of commits, each of which have an
informative message. This means that previously merged commits do not
appear in the history of the PR. For more information on cleaning up the
commits in your PR, [see this
page](https://github.com/Azure/azure-powershell/blob/master/documentation/development-docs/cleaning-up-commits.md).

### Testing Guidelines
- [ ] Pull request includes test coverage for the included changes.
  • Loading branch information
zhengfeiwang authored Jan 26, 2024
1 parent 2153885 commit a950108
Showing 1 changed file with 0 additions and 4 deletions.
4 changes: 0 additions & 4 deletions src/promptflow/promptflow/_sdk/_orm/session.py
Original file line number Diff line number Diff line change
Expand Up @@ -32,10 +32,6 @@
use_customized_encryption_key,
)

# silence RemovedIn20Warning to avoid unexpected warning message printed to users
# TODO(2587221: migrate to SQLAlchemy 2.0)
os.environ["SQLALCHEMY_SILENCE_UBER_WARNING"] = "1"

session_maker = None
lock = FileLock(LOCAL_MGMT_DB_SESSION_ACQUIRE_LOCK_PATH)

Expand Down

0 comments on commit a950108

Please sign in to comment.