Fix nits

microsoft · Oct 23, 2023 · f38a89f · f38a89f
1 parent 6673310
commit f38a89f
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 1 deletion.
diff --git a/src/promptflow/promptflow/_sdk/_utils.py b/src/promptflow/promptflow/_sdk/_utils.py
@@ -50,6 +50,7 @@
     USE_VARIANTS,
     VARIANTS,
     CommonYamlFields,
+    ConnectionType,
 )
 from promptflow._sdk._errors import (
     ConnectionNotFoundError,
@@ -811,7 +812,11 @@ def get_local_connections_from_executable(executable, client):
     for n in connection_names:
         try:
             conn = client.connections.get(name=n, with_secrets=True)
-            if conn.api_base == "dummy_base" and conn.api_key == "dummy_key":
+            if (
+                conn.TYPE == ConnectionType.AZURE_OPEN_AI
+                and conn.api_base == "dummy_base"
+                and conn.api_key == "dummy_key"
+            ):
                 if os.environ.get("PF_RECORDING_MODE", None) == "replay":
                     return {}
             result[n] = conn._to_execution_connection_dict()

diff --git a/src/promptflow/tests/sdk_cli_test/e2etests/test_flow_run.py b/src/promptflow/tests/sdk_cli_test/e2etests/test_flow_run.py
@@ -356,6 +356,8 @@ def test_connection_overwrite_model(self, local_client, local_aoai_connection):
         assert run.status == "Completed"
 
     def test_resolve_connection(self, local_client, local_aoai_connection):
+        if os.environ.get("PF_RECORDING_MODE", None) == "replay":
+            pytest.skip("Skip this test in replay mode, expected")
         flow = load_flow(f"{FLOWS_DIR}/web_classification_no_variants")
         connections = SubmitterHelper.resolve_connections(flow, local_client)
         assert local_aoai_connection.name in connections