Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[promptflow][Release] 1.0.0 release branch merge back #1064

Merged
merged 17 commits into from
Nov 10, 2023

Conversation

zhengfeiwang
Copy link
Contributor

@zhengfeiwang zhengfeiwang commented Nov 9, 2023

Description

Merge release branch for promptflow 1.0.0 back to main branch.

All Promptflow Contribution checklist:

  • The pull request does not introduce [breaking changes].
  • CHANGELOG is updated for new features, bug fixes or other significant changes.
  • I have read the contribution guidelines.
  • Create an issue and link to the pull request to get dedicated review from promptflow team. Learn more: suggested workflow.

General Guidelines and Best Practices

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • Pull request includes test coverage for the included changes.

zhengfeiwang and others added 8 commits November 9, 2023 13:56
…_output (#1037)

# Description

Please add an informative description that covers that changes made by
the pull request and link all relevant issues.

# All Promptflow Contribution checklist:
- [ ] **The pull request does not introduce [breaking changes].**
- [ ] **CHANGELOG is updated for new features, bug fixes or other
significant changes.**
- [ ] **I have read the [contribution guidelines](../CONTRIBUTING.md).**
- [ ] **Create an issue and link to the pull request to get dedicated
review from promptflow team. Learn more: [suggested
workflow](../CONTRIBUTING.md#suggested-workflow).**

## General Guidelines and Best Practices
- [ ] Title of the pull request is clear and informative.
- [ ] There are a small number of commits, each of which have an
informative message. This means that previously merged commits do not
appear in the history of the PR. For more information on cleaning up the
commits in your PR, [see this
page](https://github.com/Azure/azure-powershell/blob/master/documentation/development-docs/cleaning-up-commits.md).

### Testing Guidelines
- [ ] Pull request includes test coverage for the included changes.
…rent systems. (#1038)

# Description
To enable test cases to work on different systems(win, mac, linux), set
the process start method to spawn.


# All Promptflow Contribution checklist:
- [ ] **The pull request does not introduce [breaking changes].**
- [ ] **CHANGELOG is updated for new features, bug fixes or other
significant changes.**
- [ ] **I have read the [contribution guidelines](../CONTRIBUTING.md).**
- [ ] **Create an issue and link to the pull request to get dedicated
review from promptflow team. Learn more: [suggested
workflow](../CONTRIBUTING.md#suggested-workflow).**

## General Guidelines and Best Practices
- [ ] Title of the pull request is clear and informative.
- [ ] There are a small number of commits, each of which have an
informative message. This means that previously merged commits do not
appear in the history of the PR. For more information on cleaning up the
commits in your PR, [see this
page](https://github.com/Azure/azure-powershell/blob/master/documentation/development-docs/cleaning-up-commits.md).

### Testing Guidelines
- [ ] Pull request includes test coverage for the included changes.
)

# Description

Skip test `test_ensure_node_inputs_type` in Python 3.11 due to known
enum issue.

# All Promptflow Contribution checklist:
- [x] **The pull request does not introduce [breaking changes].**
- [ ] **CHANGELOG is updated for new features, bug fixes or other
significant changes.**
- [x] **I have read the [contribution guidelines](../CONTRIBUTING.md).**
- [ ] **Create an issue and link to the pull request to get dedicated
review from promptflow team. Learn more: [suggested
workflow](../CONTRIBUTING.md#suggested-workflow).**

## General Guidelines and Best Practices
- [x] Title of the pull request is clear and informative.
- [x] There are a small number of commits, each of which have an
informative message. This means that previously merged commits do not
appear in the history of the PR. For more information on cleaning up the
commits in your PR, [see this
page](https://github.com/Azure/azure-powershell/blob/master/documentation/development-docs/cleaning-up-commits.md).

### Testing Guidelines
- [x] Pull request includes test coverage for the included changes.

---------

Co-authored-by: Hhhilulu <[email protected]>
# Description

Fix test_thread_utils.

# All Promptflow Contribution checklist:
- [x] **The pull request does not introduce [breaking changes].**
- [ ] **CHANGELOG is updated for new features, bug fixes or other
significant changes.**
- [x] **I have read the [contribution guidelines](../CONTRIBUTING.md).**
- [ ] **Create an issue and link to the pull request to get dedicated
review from promptflow team. Learn more: [suggested
workflow](../CONTRIBUTING.md#suggested-workflow).**

## General Guidelines and Best Practices
- [x] Title of the pull request is clear and informative.
- [x] There are a small number of commits, each of which have an
informative message. This means that previously merged commits do not
appear in the history of the PR. For more information on cleaning up the
commits in your PR, [see this
page](https://github.com/Azure/azure-powershell/blob/master/documentation/development-docs/cleaning-up-commits.md).

### Testing Guidelines
- [x] Pull request includes test coverage for the included changes.

---------

Co-authored-by: Lina Tang <[email protected]>
…1051)

# Description

If run status is failed, print error message; otherwise, user cannot
know why the run is failed in SDK experience.

SDK experience:

<img width="1112" alt="image"
src="https://github.com/microsoft/promptflow/assets/38847871/8441b759-da46-4268-aadf-26a72ea8c670">

CLI experience:

<img width="1115" alt="image"
src="https://github.com/microsoft/promptflow/assets/38847871/702a1596-0a0b-45b1-b40e-549d0614b927">

# All Promptflow Contribution checklist:
- [x] **The pull request does not introduce [breaking changes].**
- [ ] **CHANGELOG is updated for new features, bug fixes or other
significant changes.**
- [x] **I have read the [contribution guidelines](../CONTRIBUTING.md).**
- [ ] **Create an issue and link to the pull request to get dedicated
review from promptflow team. Learn more: [suggested
workflow](../CONTRIBUTING.md#suggested-workflow).**

## General Guidelines and Best Practices
- [x] Title of the pull request is clear and informative.
- [x] There are a small number of commits, each of which have an
informative message. This means that previously merged commits do not
appear in the history of the PR. For more information on cleaning up the
commits in your PR, [see this
page](https://github.com/Azure/azure-powershell/blob/master/documentation/development-docs/cleaning-up-commits.md).

### Testing Guidelines
- [x] Pull request includes test coverage for the included changes.
…1061)

# Description

In some cases, inputs line number may not have full set (e.g. line 1, 2,
4), so that we should not pad the outputs from line number 0. This PR
updates the padding function parameter, so that padding will be applied
according to the real line number.

# All Promptflow Contribution checklist:
- [x] **The pull request does not introduce [breaking changes].**
- [ ] **CHANGELOG is updated for new features, bug fixes or other
significant changes.**
- [x] **I have read the [contribution guidelines](../CONTRIBUTING.md).**
- [ ] **Create an issue and link to the pull request to get dedicated
review from promptflow team. Learn more: [suggested
workflow](../CONTRIBUTING.md#suggested-workflow).**

## General Guidelines and Best Practices
- [x] Title of the pull request is clear and informative.
- [x] There are a small number of commits, each of which have an
informative message. This means that previously merged commits do not
appear in the history of the PR. For more information on cleaning up the
commits in your PR, [see this
page](https://github.com/Azure/azure-powershell/blob/master/documentation/development-docs/cleaning-up-commits.md).

### Testing Guidelines
- [x] Pull request includes test coverage for the included changes.
Copy link

github-actions bot commented Nov 9, 2023

SDK CLI Global Config Test Result release/promptflow/1.0.0

2 tests   2 ✔️  44s ⏱️
1 suites  0 💤
1 files    0

Results for commit 612ceaa.

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented Nov 9, 2023

Executor Unit Test Result release/promptflow/1.0.0

415 tests   415 ✔️  49s ⏱️
    1 suites      0 💤
    1 files        0

Results for commit 612ceaa.

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented Nov 9, 2023

promptflow SDK CLI Azure E2E Test Result release/promptflow/1.0.0

    2 files    2 suites   57s ⏱️
  56 tests 36 ✔️ 20 💤 0
112 runs  72 ✔️ 40 💤 0

Results for commit 612ceaa.

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented Nov 9, 2023

Executor E2E Test Result release/promptflow/1.0.0

129 tests   127 ✔️  1m 44s ⏱️
    1 suites      2 💤
    1 files        0

Results for commit 612ceaa.

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented Nov 9, 2023

SDK CLI Test Result release/promptflow/1.0.0

348 tests   336 ✔️  7m 30s ⏱️
    1 suites    12 💤
    1 files        0

Results for commit 612ceaa.

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented Nov 9, 2023

SDK PFS E2E Test Result release/promptflow/1.0.0

8 tests   8 ✔️  25s ⏱️
1 suites  0 💤
1 files    0

Results for commit 612ceaa.

♻️ This comment has been updated with latest results.

@zhengfeiwang zhengfeiwang merged commit c095046 into main Nov 10, 2023
46 checks passed
@zhengfeiwang zhengfeiwang deleted the release/promptflow/1.0.0 branch November 10, 2023 03:21
@zhengfeiwang zhengfeiwang restored the release/promptflow/1.0.0 branch November 10, 2023 03:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
examples Improvements on examples promptflow sdk prompt flow SDK
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants