Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create workflow to upload msi to storage account. #1122

Merged
merged 37 commits into from
Nov 16, 2023
Merged

Create workflow to upload msi to storage account. #1122

merged 37 commits into from
Nov 16, 2023

Conversation

YingChen1996
Copy link
Contributor

@YingChen1996 YingChen1996 commented Nov 14, 2023 •
edited by wangchao1230
Loading

Description

workflow link

All Promptflow Contribution checklist:

  • The pull request does not introduce [breaking changes].
  • CHANGELOG is updated for new features, bug fixes or other significant changes.
  • I have read the contribution guidelines.
  • Create an issue and link to the pull request to get dedicated review from promptflow team. Learn more: suggested workflow.

General Guidelines and Best Practices

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • Pull request includes test coverage for the included changes.

@YingChen1996 YingChen1996 requested a review from a team as a code owner November 14, 2023 06:56
@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 14, 2023 •
edited
Loading

SDK CLI Global Config Test Result chenyin/add_msi_installer_ci

2 tests   2 ✔️  59s ⏱️
1 suites  0 💤
1 files    0 ❌

Results for commit cbdf3a9.

♻️ This comment has been updated with latest results.

@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 14, 2023 •
edited
Loading

Executor Unit Test Result chenyin/add_msi_installer_ci

557 tests   557 ✔️  48s ⏱️
    1 suites      0 💤
    1 files        0 ❌

Results for commit cbdf3a9.

♻️ This comment has been updated with latest results.

@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 14, 2023 •
edited
Loading

promptflow SDK CLI Azure E2E Test Result chenyin/add_msi_installer_ci

    2 files    2 suites   1m 21s ⏱️
  57 tests 36 ✔️ 21 💤 0 ❌
114 runs  72 ✔️ 42 💤 0 ❌

Results for commit cbdf3a9.

♻️ This comment has been updated with latest results.

@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 14, 2023 •
edited
Loading

promptflow SDK CLI Azure Unit Test Result chenyin/add_msi_installer_ci

  2 files    2 suites   52s ⏱️
32 tests 30 ✔️ 2 💤 0 ❌
64 runs  60 ✔️ 4 💤 0 ❌

Results for commit cbdf3a9.

♻️ This comment has been updated with latest results.

@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 14, 2023 •
edited
Loading

SDK PFS E2E Test Result chenyin/add_msi_installer_ci

  2 files    2 suites   1m 8s ⏱️
  9 tests   9 ✔️ 0 💤 0 ❌
18 runs  18 ✔️ 0 💤 0 ❌

Results for commit cbdf3a9.

♻️ This comment has been updated with latest results.

@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 14, 2023 •
edited
Loading

Executor E2E Test Result chenyin/add_msi_installer_ci

142 tests   138 ✔️  2m 30s ⏱️
    1 suites      4 💤
    1 files        0 ❌

Results for commit cbdf3a9.

♻️ This comment has been updated with latest results.

@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 14, 2023 •
edited
Loading

SDK CLI Test Result chenyin/add_msi_installer_ci

350 tests   337 ✔️  10m 27s ⏱️
    1 suites    13 💤
    1 files        0 ❌

Results for commit cbdf3a9.

♻️ This comment has been updated with latest results.

@lalala123123
[msi] remove pfs service installer (#1151)
33fbf1e 
# Description

Please add an informative description that covers that changes made by
the pull request and link all relevant issues.

# All Promptflow Contribution checklist:
- [ ] **The pull request does not introduce [breaking changes].**
- [ ] **CHANGELOG is updated for new features, bug fixes or other
significant changes.**
- [ ] **I have read the [contribution guidelines](../CONTRIBUTING.md).**
- [ ] **Create an issue and link to the pull request to get dedicated
review from promptflow team. Learn more: [suggested
workflow](../CONTRIBUTING.md#suggested-workflow).**

## General Guidelines and Best Practices
- [ ] Title of the pull request is clear and informative.
- [ ] There are a small number of commits, each of which have an
informative message. This means that previously merged commits do not
appear in the history of the PR. For more information on cleaning up the
commits in your PR, [see this
page](https://github.com/Azure/azure-powershell/blob/master/documentation/development-docs/cleaning-up-commits.md).

### Testing Guidelines
- [ ] Pull request includes test coverage for the included changes.
@YingChen1996 YingChen1996 merged commit d1d5a59 into main Nov 16, 2023
36 checks passed
@YingChen1996 YingChen1996 deleted the chenyin/add_msi_installer_ci branch November 16, 2023 05:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wangchao1230 wangchao1230 wangchao1230 approved these changes

@lalala123123 lalala123123 lalala123123 approved these changes

Assignees
No one assigned
Labels
fundamental
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@YingChen1996 @lalala123123 @wangchao1230