[BatchEngine] Chat group poc with batch engine, chat group orchestrator changes #2360
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
promptflow
executor
PeiwenGaoMS
reviewed
Mar 15, 2024
Bixiaodi
force-pushed
the
bixiaodi/chat_group_contract
branch
from
2ee18aa to
5e5fc0a
Compare
PeiwenGaoMS
reviewed
Mar 18, 2024
src/promptflow/promptflow/batch/_chat_group_orchestrator_proxy.py
Outdated
Show resolved
Hide resolved
PeiwenGaoMS
reviewed
Mar 18, 2024
src/promptflow/promptflow/orchestrator/_chat_group_orchestrator.py
Outdated
Show resolved
Hide resolved
Bixiaodi
force-pushed
the
bixiaodi/chat_group_contract
branch
from
5e5fc0a to
82d0fda
Compare
added 7 commits
April 1, 2024 16:14
Refine code init orchestrator when create orchestrator proxy resolve conflict and refine code using executor proxy factory resolve confict and refine fix test implement orchestrator Refine code to use proxy factory Add a python single line proxy and e2e test refine code to use current interface and add e2e test fix register executor proxy in test move chat group contract to seperated file and refine refine Use proxy property Pass chat group proxy directly update test remove useless parameter update
Bixiaodi
force-pushed
the
bixiaodi/chat_group_contract
branch
from
e2985bc to
93abff7
Compare
Bixiaodi
force-pushed
the
bixiaodi/chat_group_contract
branch
from
93abff7 to
60e770f
Compare
SDK CLI Global Config Test Result bixiaodi/chat_group_contract3 tests 3 ✅ 45s ⏱️ Results for commit 60e770f. |
Executor Unit Test Result bixiaodi/chat_group_contract743 tests 741 ✅ 3m 43s ⏱️ For more details on these errors, see this check. Results for commit 60e770f. |
Executor E2E Test Result bixiaodi/chat_group_contract219 tests 212 ✅ 5m 3s ⏱️ For more details on these failures, see this check. Results for commit 60e770f. |
Bowen-Guo
reviewed
Apr 2, 2024
| from promptflow.storage._run_storage import AbstractRunStorage | ||
|
|
||
|
|
||
| class ChatGroupOrchestratorProxy(AbstractExecutorProxy): |
There was a problem hiding this comment.
Add this class in promptflow._internal? Because runtime needs to import it.
Bowen-Guo
reviewed
Apr 2, 2024
| from promptflow._sdk.entities._run import Run | ||
| from promptflow._sdk.operations._local_storage_operations import LocalStorageOperations | ||
| from promptflow._utils.utils import dump_list_to_jsonl | ||
| from promptflow.batch._batch_engine import BatchEngine | ||
| from promptflow.batch._errors import EmptyInputsData | ||
| from promptflow.batch._result import BatchResult | ||
| from promptflow._proxy._single_line_python_executor_proxy import SingleLinePythonExecutorProxy | ||
| from promptflow._proxy._chat_group_orchestrator_proxy import ChatGroupOrchestratorProxy | ||
| from promptflow._sdk.entities._chat_group._chat_role import ChatRole |
There was a problem hiding this comment.
Please also include this in the promptflow_internal? Because runtime needs to import it.
Bowen-Guo
reviewed
Apr 2, 2024
| stop_signal: Optional[str] = None, | ||
| flow_file: Optional[Path] = None, | ||
| working_dir: Optional[Path] = None, | ||
| connections: Optional[Dict[str, Any]] = None, |
There was a problem hiding this comment.
Do we need to send environment variable here?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add a chat group proxy to support chat group scenario.
Chat group proxy will be passed directly to batch engine. All the executor proxy will be created when initialize chat group proxy.
Chat group orchestrator schedule flow runs and resolve flow inputs and outputs for each run.
All Promptflow Contribution checklist:
General Guidelines and Best Practices
Testing Guidelines