Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Redirect print content to log for flex. #2441

Merged
merged 3 commits into from
Apr 3, 2024
Merged

Redirect print content to log for flex. #2441

merged 3 commits into from
Apr 3, 2024

Conversation

huaiyan
Copy link
Contributor

@huaiyan huaiyan commented Mar 22, 2024 •
edited
Loading

Description

Use NodeLogManager to redirect customer print content for flex run.
Then customer could see print content in log file.
We will print the content to flow_logger or logger.
image

All Promptflow Contribution checklist:

  • The pull request does not introduce [breaking changes].
  • CHANGELOG is updated for new features, bug fixes or other significant changes.
  • I have read the contribution guidelines.
  • Create an issue and link to the pull request to get dedicated review from promptflow team. Learn more: suggested workflow.

General Guidelines and Best Practices

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • Pull request includes test coverage for the included changes.

@huaiyan huaiyan requested review from a team as code owners March 22, 2024 03:26
@github-actions github-actions bot added promptflow executor The changes related to the execution of the flow labels Mar 22, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 22, 2024 •
edited
Loading

SDK CLI Global Config Test Result devs/robbenwang_flex_log

3 tests   3 ✅  45s ⏱️
1 suites  0 💤
1 files    0 ❌

Results for commit 32b7a3f.

♻️ This comment has been updated with latest results.

@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 22, 2024 •
edited
Loading

promptflow SDK CLI Azure E2E Test Result devs/robbenwang_flex_log

  4 files    4 suites   3m 59s ⏱️
202 tests 182 ✅ 20 💤 0 ❌
808 runs  728 ✅ 80 💤 0 ❌

Results for commit 32b7a3f.

♻️ This comment has been updated with latest results.

@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 22, 2024 •
edited
Loading

Executor Unit Test Result devs/robbenwang_flex_log

754 tests   754 ✅  3m 43s ⏱️
  1 suites    0 💤
  1 files      0 ❌

Results for commit 32b7a3f.

♻️ This comment has been updated with latest results.

@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 22, 2024 •
edited
Loading

Executor E2E Test Result devs/robbenwang_flex_log

218 tests   216 ✅  5m 30s ⏱️
  1 suites    2 💤
  1 files      0 ❌

Results for commit 32b7a3f.

♻️ This comment has been updated with latest results.

@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 22, 2024 •
edited
Loading

SDK CLI Test Result devs/robbenwang_flex_log

   12 files     12 suites   50m 49s ⏱️
  526 tests   507 ✅ 19 💤 0 ❌
2 104 runs  2 028 ✅ 76 💤 0 ❌

Results for commit 32b7a3f.

♻️ This comment has been updated with latest results.

@huaiyan huaiyan force-pushed the devs/robbenwang_flex_log branch from b97ea35 to 8f70a02 Compare March 22, 2024 03:59
@huaiyan huaiyan force-pushed the devs/robbenwang_flex_log branch from 8f70a02 to 8a0fab0 Compare March 28, 2024 02:54
@huaiyan huaiyan force-pushed the devs/robbenwang_flex_log branch from 8a0fab0 to f7698b7 Compare March 28, 2024 03:41
@huaiyan huaiyan force-pushed the devs/robbenwang_flex_log branch from f7698b7 to 9a185fa Compare March 28, 2024 07:54
@huaiyan huaiyan force-pushed the devs/robbenwang_flex_log branch from 9a185fa to ab78f76 Compare March 28, 2024 11:37
@huaiyan huaiyan force-pushed the devs/robbenwang_flex_log branch from ab78f76 to dfdcd7d Compare March 29, 2024 03:19
@huaiyan huaiyan requested a review from D-W- March 29, 2024 03:31
@huaiyan huaiyan changed the title add log for flow log for flex. Redirect print content to log for flex. Mar 29, 2024
@huaiyan huaiyan force-pushed the devs/robbenwang_flex_log branch from dfdcd7d to a20fb3d Compare April 1, 2024 02:50
@huaiyan huaiyan force-pushed the devs/robbenwang_flex_log branch from a20fb3d to 32b7a3f Compare April 1, 2024 10:47
@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 1, 2024

promptflow-core test result

 12 files   12 suites   2m 52s ⏱️
 11 tests  11 ✅ 0 💤 0 ❌
132 runs  132 ✅ 0 💤 0 ❌

Results for commit 32b7a3f.

@huaiyan huaiyan merged commit 775095d into main Apr 3, 2024
58 checks passed
@huaiyan huaiyan deleted the devs/robbenwang_flex_log branch April 3, 2024 06:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thy09 thy09 thy09 approved these changes

@D-W- D-W- D-W- approved these changes

Assignees
No one assigned
Labels
executor The changes related to the execution of the flow promptflow
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@huaiyan @thy09 @D-W-