[Tracing][Internal] Use otel_trace_id for correlation between line run and otel trace #2553
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
promptflow
executor
promptflow-tracing test result 12 files 12 suites 3m 47s ⏱️ Results for commit 6950f4f. ♻️ This comment has been updated with latest results. |
zzn2
previously approved these changes
Mar 29, 2024
zzn2
previously approved these changes
Mar 29, 2024
thy09
force-pushed
the
heta/add-otel-trace-id-in-line-run
branch
from
a7fcceb to
771e68c
Compare
promptflow SDK CLI Azure E2E Test Result heta/add-otel-trace-id-in-line-run 4 files 4 suites 3m 59s ⏱️ Results for commit 6950f4f. ♻️ This comment has been updated with latest results. |
Executor E2E Test Result heta/add-otel-trace-id-in-line-run223 tests 221 ✅ 6m 40s ⏱️ Results for commit 6950f4f. ♻️ This comment has been updated with latest results. |
SDK CLI Test Result heta/add-otel-trace-id-in-line-run 12 files 12 suites 48m 15s ⏱️ Results for commit 6950f4f. ♻️ This comment has been updated with latest results. |
huaiyan
approved these changes
Mar 29, 2024
zzn2
approved these changes
Apr 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Use otel_trace_id for correlation between line run and otel trace.
This pull request primarily focuses on enhancing the traceability of operations in the codebase. The changes involve storing the OpenTelemetry (otel) trace ID in the PromptFlow (pf) trace for correlation. This is achieved by introducing the
OperationContextclass and adding theotel_trace_idattribute to theFlowRunInfoclass.Here are the key changes:
Traceability enhancements:
src/promptflow-core/promptflow/_core/run_tracker.py: ImportedOperationContextclass and stored the otel trace ID in pf trace for correlation in the_flow_run_postprocessmethod. [1] [2]src/promptflow-core/promptflow/contracts/run_info.py: Addedotel_trace_idattribute to theFlowRunInfoclass.src/promptflow-core/promptflow/executor/flow_executor.py,src/promptflow-tracing/promptflow/tracing/_trace.py: Stored the otel trace ID in pf trace for correlation in the_exec_inner_with_trace,wrapped(async and sync versions) methods. [1] [2] [3]All Promptflow Contribution checklist:
General Guidelines and Best Practices
Testing Guidelines