Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Draft][Batch][Flex] Directly call async function in batch engine for flex mode. #2569

Closed
wants to merge 2 commits into from

Conversation

thy09
Copy link
Contributor

@thy09 thy09 commented Apr 1, 2024

Description

When the user provides an async function as the entry of flex flow, we are still using a process pool to run each lines.
However we can actually expose exec_line_async which directly call the async entry function, then we can leverage the async part of the batch engine.

All Promptflow Contribution checklist:

  • The pull request does not introduce [breaking changes].
  • CHANGELOG is updated for new features, bug fixes or other significant changes.
  • I have read the contribution guidelines.
  • Create an issue and link to the pull request to get dedicated review from promptflow team. Learn more: suggested workflow.

General Guidelines and Best Practices

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • Pull request includes test coverage for the included changes.

@thy09 thy09 requested a review from a team as a code owner April 1, 2024 03:55
@github-actions github-actions bot added promptflow executor The changes related to the execution of the flow labels Apr 1, 2024
Copy link

github-actions bot commented Apr 1, 2024

promptflow SDK CLI Azure E2E Test Result heta/call-async-function-directly

  4 files    4 suites   4m 14s ⏱️
201 tests 181 ✅ 20 💤 0 ❌
804 runs  724 ✅ 80 💤 0 ❌

Results for commit 9fd4c74.

Copy link

github-actions bot commented Apr 1, 2024

SDK CLI Test Result heta/call-async-function-directly

   12 files     12 suites   48m 29s ⏱️
  513 tests   494 ✅ 19 💤 0 ❌
2 052 runs  1 976 ✅ 76 💤 0 ❌

Results for commit 9fd4c74.

Copy link

Hi, thank you for your interest in helping to improve the prompt flow experience and for your contribution. We've noticed that there hasn't been recent engagement on this pull request. If this is still an active work stream, please let us know by pushing some changes or leaving a comment.

@github-actions github-actions bot added the no-recent-activity There has been no recent activity on this issue/pull request label Apr 15, 2024
Copy link

Hi, thank you for your contribution. Since there has not been recent engagement, we are going to close this out. Feel free to reopen if you'd like to continue working on these changes. Please be sure to remove the no-recent-activity label; otherwise, this is likely to be closed again with the next cleanup pass.

@github-actions github-actions bot closed this Apr 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
executor The changes related to the execution of the flow no-recent-activity There has been no recent activity on this issue/pull request promptflow
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant