Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fundamental][bugfix] Refine dev setup script to not automatically touch __init__.py #2571

Merged
merged 4 commits into from
Apr 1, 2024

Conversation

zhengfeiwang
Copy link
Contributor

@zhengfeiwang zhengfeiwang commented Apr 1, 2024

Description

  • Add a parameter vscode for dev setup script, so that the script will not automatically touch those __init__.py files.
  • Bump promptflow-core version to 1.1.0.dev0 following the new version design/decision.

All Promptflow Contribution checklist:

  • The pull request does not introduce [breaking changes].
  • CHANGELOG is updated for new features, bug fixes or other significant changes.
  • I have read the contribution guidelines.
  • Create an issue and link to the pull request to get dedicated review from promptflow team. Learn more: suggested workflow.

General Guidelines and Best Practices

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • Pull request includes test coverage for the included changes.

@zhengfeiwang zhengfeiwang requested a review from a team as a code owner April 1, 2024 04:41
@github-actions github-actions bot added documentation Improvements or additions to documentation promptflow fundamental labels Apr 1, 2024
Copy link

github-actions bot commented Apr 1, 2024

SDK CLI Global Config Test Result zhengfei/bugfix/dev-setup

3 tests   3 ✅  43s ⏱️
1 suites  0 💤
1 files    0 ❌

Results for commit 79838ae.

Copy link

github-actions bot commented Apr 1, 2024

promptflow SDK CLI Azure E2E Test Result zhengfei/bugfix/dev-setup

  4 files    4 suites   4m 4s ⏱️
201 tests 181 ✅ 20 💤 0 ❌
804 runs  724 ✅ 80 💤 0 ❌

Results for commit 79838ae.

Copy link

github-actions bot commented Apr 1, 2024

Executor Unit Test Result zhengfei/bugfix/dev-setup

754 tests   754 ✅  3m 44s ⏱️
  1 suites    0 💤
  1 files      0 ❌

Results for commit 79838ae.

Copy link

github-actions bot commented Apr 1, 2024

Executor E2E Test Result zhengfei/bugfix/dev-setup

223 tests   221 ✅  5m 34s ⏱️
  1 suites    2 💤
  1 files      0 ❌

Results for commit 79838ae.

Copy link

github-actions bot commented Apr 1, 2024

SDK CLI Test Result zhengfei/bugfix/dev-setup

   12 files     12 suites   48m 49s ⏱️
  513 tests   494 ✅ 19 💤 0 ❌
2 052 runs  1 976 ✅ 76 💤 0 ❌

Results for commit 79838ae.

@zhengfeiwang zhengfeiwang merged commit 72ffee0 into main Apr 1, 2024
44 checks passed
@zhengfeiwang zhengfeiwang deleted the zhengfei/bugfix/dev-setup branch April 1, 2024 07:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation fundamental promptflow
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants