Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use batch run id as evaluation dict's key for batch run. #2574

Merged
merged 2 commits into from
Apr 1, 2024

Conversation

huaiyan
Copy link
Contributor

@huaiyan huaiyan commented Apr 1, 2024

Description

Use batch run id as evaluation dict's key for batch run.
https://int.ml.azure.com/prompts/trace/list?wsid=/subscriptions/96aede12-2f73-41cb-b983-6d11a904839b/resourceGroups/promptflow/providers/Microsoft.MachineLearningServices/workspaces/promptflow-canary-dev&searchText={%22batchRunId%22:%22test_main_variant_0_20240401_095544_611576%22}&tid=72f988bf-86f1-41af-91ab-2d7cd011db47
Current UX can't show eval output in LineSummary list after this change.
Because UX will update to new UI soon, we accept this breaking change.
image
image

All Promptflow Contribution checklist:

  • The pull request does not introduce [breaking changes].
  • CHANGELOG is updated for new features, bug fixes or other significant changes.
  • I have read the contribution guidelines.
  • Create an issue and link to the pull request to get dedicated review from promptflow team. Learn more: suggested workflow.

General Guidelines and Best Practices

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • Pull request includes test coverage for the included changes.

@huaiyan huaiyan requested a review from a team as a code owner April 1, 2024 06:57
@github-actions github-actions bot added the sdk prompt flow SDK label Apr 1, 2024
Copy link

github-actions bot commented Apr 1, 2024

SDK CLI Global Config Test Result dev/robbenwang_eval_key

3 tests   3 ✅  45s ⏱️
1 suites  0 💤
1 files    0 ❌

Results for commit 2f5a1a8.

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented Apr 1, 2024

promptflow SDK CLI Azure E2E Test Result dev/robbenwang_eval_key

  4 files    4 suites   4m 1s ⏱️
202 tests 182 ✅ 20 💤 0 ❌
808 runs  728 ✅ 80 💤 0 ❌

Results for commit 2f5a1a8.

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented Apr 1, 2024

SDK CLI Test Result dev/robbenwang_eval_key

   12 files     12 suites   51m 15s ⏱️
  526 tests   507 ✅ 19 💤 0 ❌
2 104 runs  2 028 ✅ 76 💤 0 ❌

Results for commit 2f5a1a8.

♻️ This comment has been updated with latest results.

@huaiyan huaiyan force-pushed the dev/robbenwang_eval_key branch from ad77f64 to 2f5a1a8 Compare April 1, 2024 11:06
@huaiyan huaiyan merged commit 1c904f0 into main Apr 1, 2024
34 checks passed
@huaiyan huaiyan deleted the dev/robbenwang_eval_key branch April 1, 2024 11:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
sdk prompt flow SDK
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants