-
Notifications
You must be signed in to change notification settings - Fork 894
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[tracing/devkit] start_trace
just merge new resources
#2583
[tracing/devkit] start_trace
just merge new resources
#2583
Conversation
promptflow-tracing test result 12 files 12 suites 10s ⏱️ Results for commit a044542. ♻️ This comment has been updated with latest results. |
promptflow SDK CLI Azure E2E Test Result zhengfei/bugfix/not-overwrite-trace-provider 4 files 4 suites 4m 2s ⏱️ Results for commit a044542. ♻️ This comment has been updated with latest results. |
Executor E2E Test Result zhengfei/bugfix/not-overwrite-trace-provider223 tests 221 ✅ 6m 13s ⏱️ Results for commit a044542. ♻️ This comment has been updated with latest results. |
SDK CLI Global Config Test Result zhengfei/bugfix/not-overwrite-trace-provider3 tests 3 ✅ 43s ⏱️ Results for commit a044542. ♻️ This comment has been updated with latest results. |
SDK CLI Test Result zhengfei/bugfix/not-overwrite-trace-provider 12 files 12 suites 47m 50s ⏱️ Results for commit a044542. ♻️ This comment has been updated with latest results. |
Executor Unit Test Result zhengfei/bugfix/not-overwrite-trace-provider771 tests 771 ✅ 3m 45s ⏱️ Results for commit a044542. ♻️ This comment has been updated with latest results. |
Description
This PR targets to update the behavior of
start_trace
: when tracer provider is set, does not overwrite it, but merge new resource attributes to the existing one. So thatstart_trace
will not pollute user custom tracer provider.All Promptflow Contribution checklist:
General Guidelines and Best Practices
Testing Guidelines