Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[tracing/devkit] start_trace just merge new resources #2583

Merged
merged 12 commits into from
Apr 10, 2024

Conversation

zhengfeiwang
Copy link
Contributor

@zhengfeiwang zhengfeiwang commented Apr 1, 2024

Description

This PR targets to update the behavior of start_trace: when tracer provider is set, does not overwrite it, but merge new resource attributes to the existing one. So that start_trace will not pollute user custom tracer provider.

All Promptflow Contribution checklist:

  • The pull request does not introduce [breaking changes].
  • CHANGELOG is updated for new features, bug fixes or other significant changes.
  • I have read the contribution guidelines.
  • Create an issue and link to the pull request to get dedicated review from promptflow team. Learn more: suggested workflow.

General Guidelines and Best Practices

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • Pull request includes test coverage for the included changes.

Copy link

github-actions bot commented Apr 1, 2024

promptflow-tracing test result

 12 files   12 suites   10s ⏱️
 48 tests  48 ✅ 0 💤 0 ❌
576 runs  576 ✅ 0 💤 0 ❌

Results for commit a044542.

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented Apr 1, 2024

promptflow SDK CLI Azure E2E Test Result zhengfei/bugfix/not-overwrite-trace-provider

  4 files    4 suites   4m 2s ⏱️
205 tests 185 ✅ 20 💤 0 ❌
820 runs  740 ✅ 80 💤 0 ❌

Results for commit a044542.

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented Apr 1, 2024

Executor E2E Test Result zhengfei/bugfix/not-overwrite-trace-provider

223 tests   221 ✅  6m 13s ⏱️
  1 suites    2 💤
  1 files      0 ❌

Results for commit a044542.

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented Apr 1, 2024

SDK CLI Global Config Test Result zhengfei/bugfix/not-overwrite-trace-provider

3 tests   3 ✅  43s ⏱️
1 suites  0 💤
1 files    0 ❌

Results for commit a044542.

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented Apr 1, 2024

SDK CLI Test Result zhengfei/bugfix/not-overwrite-trace-provider

   12 files     12 suites   47m 50s ⏱️
  566 tests   547 ✅ 19 💤 0 ❌
2 264 runs  2 188 ✅ 76 💤 0 ❌

Results for commit a044542.

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented Apr 9, 2024

Executor Unit Test Result zhengfei/bugfix/not-overwrite-trace-provider

771 tests   771 ✅  3m 45s ⏱️
  1 suites    0 💤
  1 files      0 ❌

Results for commit a044542.

♻️ This comment has been updated with latest results.

@zhengfeiwang zhengfeiwang merged commit f9f71cc into main Apr 10, 2024
72 of 73 checks passed
@zhengfeiwang zhengfeiwang deleted the zhengfei/bugfix/not-overwrite-trace-provider branch April 10, 2024 05:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants