Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix pf version #2588

Merged
merged 17 commits into from
Apr 2, 2024
Merged

Fix pf version #2588

merged 17 commits into from
Apr 2, 2024

Conversation

crazygao
Copy link
Contributor

@crazygao crazygao commented Apr 1, 2024

Description

image
image

Fix tests, user agents.
And change _entities/flow -> _entities/flows for backward compatibility.

Here is the matrix of updated promptflow UAs

  • pf cli: promptflow-cli/DEVKIT VERSION
  • from promptflow.client import PFClient: promptflow-sdk/DEVKIT VERSION
  • pfazure cli: promptflow-azure-cli/AZURE VERSION
  • from promptflow.azure import PFClient: promptflow-azure-sdk/AZURE VERSION

All Promptflow Contribution checklist:

  • The pull request does not introduce [breaking changes].
  • CHANGELOG is updated for new features, bug fixes or other significant changes.
  • I have read the contribution guidelines.
  • Create an issue and link to the pull request to get dedicated review from promptflow team. Learn more: suggested workflow.

General Guidelines and Best Practices

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • Pull request includes test coverage for the included changes.

@crazygao crazygao requested review from a team as code owners April 1, 2024 10:42
@github-actions github-actions bot added sdk prompt flow SDK cli prompt flow CLI promptflow labels Apr 1, 2024
Copy link

github-actions bot commented Apr 1, 2024

promptflow-core test result

 12 files   12 suites   3m 1s ⏱️
 11 tests  11 ✅ 0 💤 0 ❌
132 runs  132 ✅ 0 💤 0 ❌

Results for commit 50af82d.

♻️ This comment has been updated with latest results.

brynn-code
brynn-code previously approved these changes Apr 1, 2024
Copy link

github-actions bot commented Apr 1, 2024

promptflow SDK CLI Azure E2E Test Result yigao/pf_version

  4 files    4 suites   4m 3s ⏱️
202 tests 182 ✅ 20 💤 0 ❌
808 runs  728 ✅ 80 💤 0 ❌

Results for commit 50af82d.

♻️ This comment has been updated with latest results.

wangchao1230
wangchao1230 previously approved these changes Apr 1, 2024
Copy link

github-actions bot commented Apr 1, 2024

SDK CLI Test Result yigao/pf_version

   12 files     12 suites   50m 51s ⏱️
  535 tests   516 ✅ 19 💤 0 ❌
2 140 runs  2 064 ✅ 76 💤 0 ❌

Results for commit 50af82d.

♻️ This comment has been updated with latest results.

@crazygao crazygao dismissed stale reviews from wangchao1230 and brynn-code via 0dc144e April 1, 2024 11:31
@crazygao crazygao requested a review from a team as a code owner April 1, 2024 11:31
@github-actions github-actions bot added the executor The changes related to the execution of the flow label Apr 1, 2024
Copy link

github-actions bot commented Apr 1, 2024

SDK CLI Global Config Test Result yigao/pf_version

3 tests   3 ✅  51s ⏱️
1 suites  0 💤
1 files    0 ❌

Results for commit 50af82d.

♻️ This comment has been updated with latest results.

wangchao1230
wangchao1230 previously approved these changes Apr 1, 2024
Signed-off-by: Brynn Yin <[email protected]>
Signed-off-by: Brynn Yin <[email protected]>
git add .
Refine error

Signed-off-by: Brynn Yin <[email protected]>
@crazygao crazygao merged commit 2771dcf into main Apr 2, 2024
48 checks passed
@crazygao crazygao deleted the yigao/pf_version branch April 2, 2024 06:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cli prompt flow CLI executor The changes related to the execution of the flow promptflow sdk prompt flow SDK
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants