Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BatchEngine] Chat group orchestrator and related change in batch engine #2591

Merged
merged 15 commits into from
Apr 9, 2024
Merged

[BatchEngine] Chat group orchestrator and related change in batch engine #2591

merged 15 commits into from
Apr 9, 2024

Conversation

Bixiaodi
Copy link

@Bixiaodi Bixiaodi commented Apr 1, 2024

Add a chat group proxy to support chat group scenario.
Chat group proxy will be passed directly to batch engine. All the executor proxy will be created when initialize chat group proxy.
Chat group orchestrator schedule flow runs and resolve flow inputs and outputs for each run.
image

All Promptflow Contribution checklist:

  • The pull request does not introduce [breaking changes].
  • CHANGELOG is updated for new features, bug fixes or other significant changes.
  • I have read the contribution guidelines.
  • Create an issue and link to the pull request to get dedicated review from promptflow team. Learn more: suggested workflow.

General Guidelines and Best Practices

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • Pull request includes test coverage for the included changes.

@Bixiaodi Bixiaodi requested review from a team as code owners April 1, 2024 11:47
@github-actions github-actions bot added sdk prompt flow SDK promptflow executor The changes related to the execution of the flow labels Apr 1, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 1, 2024 •
edited
Loading

promptflow-core test result

0 tests   0 ✅  0s ⏱️
0 suites  0 💤
0 files    0 ❌

Results for commit 1f741aa.

♻️ This comment has been updated with latest results.

@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 1, 2024 •
edited
Loading

SDK CLI Global Config Test Result bixiaodi/chat_group_poc

3 tests   3 ✅  48s ⏱️
1 suites  0 💤
1 files    0 ❌

Results for commit 22e190a.

♻️ This comment has been updated with latest results.

@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 1, 2024 •
edited
Loading

promptflow SDK CLI Azure E2E Test Result bixiaodi/chat_group_poc

  4 files    4 suites   4m 2s ⏱️
205 tests 185 ✅ 20 💤 0 ❌
820 runs  740 ✅ 80 💤 0 ❌

Results for commit 22e190a.

♻️ This comment has been updated with latest results.

@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 1, 2024 •
edited
Loading

Executor Unit Test Result bixiaodi/chat_group_poc

771 tests   771 ✅  3m 43s ⏱️
  1 suites    0 💤
  1 files      0 ❌

Results for commit 22e190a.

♻️ This comment has been updated with latest results.

@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 1, 2024 •
edited
Loading

Executor E2E Test Result bixiaodi/chat_group_poc

223 tests   221 ✅  5m 30s ⏱️
  1 suites    2 💤
  1 files      0 ❌

Results for commit 22e190a.

♻️ This comment has been updated with latest results.

@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 1, 2024 •
edited
Loading

SDK CLI Test Result bixiaodi/chat_group_poc

   12 files     12 suites   49m 34s ⏱️
  559 tests   540 ✅ 19 💤 0 ❌
2 236 runs  2 160 ✅ 76 💤 0 ❌

Results for commit 22e190a.

♻️ This comment has been updated with latest results.

elliotzh
elliotzh previously approved these changes Apr 2, 2024
View reviewed changes
@Bixiaodi Bixiaodi force-pushed the bixiaodi/chat_group_poc branch from e7093fd to 8b1617f Compare April 2, 2024 04:11
@Bixiaodi Bixiaodi force-pushed the bixiaodi/chat_group_poc branch from 8b1617f to d21c7fc Compare April 2, 2024 04:12
@Bixiaodi Bixiaodi force-pushed the bixiaodi/chat_group_poc branch from c761ad7 to 22e190a Compare April 9, 2024 09:02
@Bixiaodi Bixiaodi merged commit 6029a62 into main Apr 9, 2024
44 checks passed
@Bixiaodi Bixiaodi deleted the bixiaodi/chat_group_poc branch April 9, 2024 10:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Bowen-Guo Bowen-Guo Bowen-Guo left review comments

@thy09 thy09 thy09 left review comments

@crazygao crazygao crazygao left review comments

@wangchao1230 wangchao1230 wangchao1230 approved these changes

@huaiyan huaiyan huaiyan approved these changes

@0mza987 0mza987 0mza987 approved these changes

@elliotzh elliotzh elliotzh left review comments

Assignees
No one assigned
Labels
executor The changes related to the execution of the flow promptflow promptflow-devkit sdk prompt flow SDK
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@Bixiaodi @crazygao @0mza987 @thy09 @huaiyan @elliotzh @Bowen-Guo @wangchao1230 @lumoslnt